-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require lowercase enums #474
Conversation
We (@ transport.data.gouv.fr) had to get in touch with multiple people in regards to this, thanks for clarifying it! |
I hereby call a vote on this proposal. Voting will be open for 10 full calendar days until 11:59PM UTC on Thursday, March 9th, 2023. Please vote for or against the proposal, and include the organization for which you are voting in your comment. Please note if you can commit to implementing the proposal. |
Entur votes in favour and will implement this proposal. |
Joyride (feed provider) votes in favour and recently made this change on our 2.3 feeds, so we will absolutely comply in 3.0. |
+1 for PBSC for version 3.0 |
+1 for Transit |
This vote has now closed, and it passes! Votes in favor: |
What problem does your proposal solve? Please begin with the relevant issue number. If there is no existing issue, please also describe alternative solutions you have considered.
As discussed on the validator repo, having both uppercase and lowercase enum values creates deserialization issues.
What is the proposal?
Modifies enum field type to say that enums MUST be lowercase, rather than SHOULD.
Is this a breaking change?
Which files are affected by this change?
cc: @testower