Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require lowercase enums #474

Merged
merged 2 commits into from
Mar 10, 2023
Merged

Require lowercase enums #474

merged 2 commits into from
Mar 10, 2023

Conversation

josee-sabourin
Copy link
Contributor

@josee-sabourin josee-sabourin commented Jan 16, 2023

What problem does your proposal solve? Please begin with the relevant issue number. If there is no existing issue, please also describe alternative solutions you have considered.

As discussed on the validator repo, having both uppercase and lowercase enum values creates deserialization issues.

What is the proposal?

Modifies enum field type to say that enums MUST be lowercase, rather than SHOULD.

Is this a breaking change?

  • Yes
  • No
  • Unsure

Which files are affected by this change?

  • vehicle_types.json
  • station_information.json
  • free_bike_status.json
  • system_alerts.json

cc: @testower

@josee-sabourin josee-sabourin changed the title require-lowercase-enums Require lowercase enums Jan 16, 2023
@AntoineAugusti
Copy link
Contributor

AntoineAugusti commented Jan 16, 2023

We (@ transport.data.gouv.fr) had to get in touch with multiple people in regards to this, thanks for clarifying it!

@josee-sabourin
Copy link
Contributor Author

I hereby call a vote on this proposal. Voting will be open for 10 full calendar days until 11:59PM UTC on Thursday, March 9th, 2023.

Please vote for or against the proposal, and include the organization for which you are voting in your comment.

Please note if you can commit to implementing the proposal.

@josee-sabourin josee-sabourin added Vote open v3.0-RC Candidate change for GBFS 3.0 (Major release) gbfs.md labels Feb 28, 2023
@testower
Copy link
Contributor

Entur votes in favour and will implement this proposal.

@benwedge
Copy link

Joyride (feed provider) votes in favour and recently made this change on our 2.3 feeds, so we will absolutely comply in 3.0.

@fbouchPBSC
Copy link
Contributor

+1 for PBSC for version 3.0

@cmonagle
Copy link
Contributor

cmonagle commented Mar 1, 2023

+1 for Transit

@josee-sabourin
Copy link
Contributor Author

This vote has now closed, and it passes!

Votes in favor:
Entur (consumer)
Joyride (producer)
PBSC (producer)
Transit (consumer)

There were no votes against.

@josee-sabourin josee-sabourin merged commit e5fe714 into master Mar 10, 2023
@josee-sabourin josee-sabourin deleted the uppercase-enums branch March 10, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gbfs.md v3.0-RC Candidate change for GBFS 3.0 (Major release) Vote Passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants