fix: validator error

MobilityData · Feb 19, 2024 · 1b99140 · 1b99140
1 parent 688b807
commit 1b99140
Showing 1 changed file with 10 additions and 8 deletions.
diff --git a/...src/main/java/org/mobilitydata/gtfsvalidator/validator/TripAndShapeDistanceValidator.java b/...src/main/java/org/mobilitydata/gtfsvalidator/validator/TripAndShapeDistanceValidator.java
@@ -85,14 +85,16 @@ public void validate(NoticeContainer noticeContainer) {
               double maxShapeDist = maxShape.shapeDistTraveled();
               double distanceInMeters =
                   getDistanceMeters(maxShape.shapePtLatLon(), stop.stopLatLon());
-              if (distanceInMeters > DISTANCE_THRESHOLD) {
-                noticeContainer.addValidationNotice(
-                    new TripDistanceExceedsShapeDistanceNotice(
-                        trip.tripId(), shapeId, maxStopTimeDist, maxShapeDist, distanceInMeters));
-              } else if (distanceInMeters > 0) {
-                noticeContainer.addValidationNotice(
-                    new TripDistanceExceedsShapeDistanceWarningNotice(
-                        trip.tripId(), shapeId, maxStopTimeDist, maxShapeDist, distanceInMeters));
+              if (maxStopTimeDist > maxShapeDist) {
+                if (distanceInMeters > DISTANCE_THRESHOLD) {
+                  noticeContainer.addValidationNotice(
+                      new TripDistanceExceedsShapeDistanceNotice(
+                          trip.tripId(), shapeId, maxStopTimeDist, maxShapeDist, distanceInMeters));
+                } else if (distanceInMeters > 0) {
+                  noticeContainer.addValidationNotice(
+                      new TripDistanceExceedsShapeDistanceWarningNotice(
+                          trip.tripId(), shapeId, maxStopTimeDist, maxShapeDist, distanceInMeters));
+                }
               }
             });
   }