Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Welcome bot and Bug triage workflows aren't working #1298

Closed
isabelle-dr opened this issue Nov 22, 2022 · 8 comments
Closed

Welcome bot and Bug triage workflows aren't working #1298

isabelle-dr opened this issue Nov 22, 2022 · 8 comments
Assignees
Labels
bug Something isn't working (crash, a rule has a problem) status: Ready An issue that is ready to be worked on. workflow Related to Github Actions, triggers, and boards.

Comments

@isabelle-dr
Copy link
Contributor

isabelle-dr commented Nov 22, 2022

Describe the bug

We have a bug triage workflow that should run every time a new issue is open with a bug label. It sends a message and adds the issue to the Bug triage board.
We have a welcome bot that sends an automatic message when:

  • someone opens an issue for the first time on this repo
  • someone opens a PR for the first time on this repo
  • a PR is merged by a first-time contributor on this repo

The welcome bot is configured in https://github.com/MobilityData/gtfs-validator/blob/master/.github/config.yml
The bug triage is configured in https://github.com/MobilityData/gtfs-validator/blob/master/.github/workflows/triage.yml

It looks like they aren't working anymore.

Steps/Code to Reproduce

The welcome bot didn't run when this PR was opened by a first-time contributor.

The bug triage didn't run when this issue was open.

Expected Results

The workflows run.

See this issue where both workflows ran in August.

Actual Results

nothing

Screenshots

No response

Files used

No response

Validator version

4.0.0

Operating system

MacOS

Java version

No response

Additional notes

No response

@isabelle-dr isabelle-dr added bug Something isn't working (crash, a rule has a problem) status: Needs triage Applied to all new issues status: Ready An issue that is ready to be worked on. and removed status: Needs triage Applied to all new issues labels Nov 22, 2022
@lionel-nj
Copy link
Contributor

lionel-nj commented Dec 5, 2022

Hello @isabelle-dr, for the triage, it looks like a column has been deleted from the repository.

To fix, you should map to the new column (Triage?)

Link to actions output

Screen Shot 2022-12-04 at 11 50 41 PM

For the welcolme bot, I am not sure you could try and check the permissions as detailed here

😃 I was just passing by to check on how my baby gtfs-validator is doing. Looks like he's been growing a lot! v4 already!! They grow up so fast! Keep up the good work 💪🏾

... GIF of the day ⬇️

fi

@isabelle-dr
Copy link
Contributor Author

Oh hey there @lionel-nj,

Your baby is doing pretty well 🐥.
Thanks for the insights on how to fix this bug. It matters to us that new contributors are welcomed with cat GIFs, a legacy of our Chief Gif Officer! 😉

@isabelle-dr
Copy link
Contributor Author

isabelle-dr commented Feb 14, 2023

The welcome bot is now fixed, but the bug triage is still broken.

I've added a "Bug triage" board with a "Requires investigation" column and I still get this message:
Screenshot 2023-02-14 at 11 17 34 AM

@jcpitre
Copy link
Contributor

jcpitre commented May 18, 2023

About bug triage, the external Github action we are using (alex-page/github-project-automation-plus) does not work with the new types of projects in Github. Apparently they have the classic version of projects, that works with the external action we use and the V2 version, that is now the default, for which the action does not work. See alex-page/github-project-automation-plus#81 (comment)

One workaround would be to create the bug triage project asa classic project. But it's possible only if we already have a classic project. I guess Github want to get rid of classic projects ASAP.

@jcpitre
Copy link
Contributor

jcpitre commented May 18, 2023

Turns out we can create classic projects, but only at the organization level right now. Tried with one and I could not retrieve it with the Github GraphQL API, meaning it's unlikely that the bug triage action will work. I think the project needs to be at the repo level.

@isabelle-dr isabelle-dr added this to the MobilityData Now milestone Jun 12, 2023
@emmambd emmambd added the workflow Related to Github Actions, triggers, and boards. label Jul 10, 2023
@fredericsimard
Copy link
Contributor

I found this, could it be why the welcome bot doesn't fire?

  • The first-time contributor might not have added their name to the contributors file in the repository. This file is used to track who has contributed to the project, and it is used by the behaviorbot to determine if a contributor is a first-time contributor.
  • The first-time contributor might not have pushed their commit to the master branch. The behaviorbot only scans the master branch for new commits, so if the first-time contributor pushed their commit to a different branch, the behaviorbot would not see it.

@fredericsimard
Copy link
Contributor

fredericsimard commented Aug 14, 2023

I've made tiny changes to the bug triage workflow, we'll see when it is triggered next if it works.

https://github.com/MobilityData/gtfs-validator/blob/master/.github/workflows/triage.yml

@fredericsimard
Copy link
Contributor

fredericsimard commented Aug 31, 2023

Bug triage is fixed. Turns out there is no need to create an action, the new Projects have Workflows you can use to do certain actions based on conditions.

I've set two workflows:

  1. moves the new issue or PR to the Bug triage project.
  2. moves the newly added item to the project in the "Requires investigation" column.

Tada!!

I've disabled the Bug triage action, we could remove the YAML entirely if this works.

@jcpitre Turns out you were 100% correct, the action doesn't work with the new Projects, because you don't need an action to accomplish this. :-)

More info on workflows

https://docs.github.com/en/issues/planning-and-tracking-with-projects/learning-about-projects/quickstart-for-projects#configure-built-in-automation

@emmambd emmambd removed this from the Now milestone Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working (crash, a rule has a problem) status: Ready An issue that is ready to be worked on. workflow Related to Github Actions, triggers, and boards.
Projects
None yet
Development

No branches or pull requests

5 participants