Best Practice: feed_info.txt should be provided (WARNING)

[e-lo]

Lack of feed_info.txt should all trigger a WARNING because the file is required in the GTFS Best Practices.

Should probably mirror or extend MissingRequiredFileNotice to allow for a parameter to indicate SeverityLevel.WARNING

gtfs-validator/core/src/main/java/org/mobilitydata/gtfsvalidator/notice/MissingRequiredFileNotice.java

Lines 27 to 29 in 5243445

	public MissingRequiredFileNotice(String filename) {
	super(ImmutableMap.of("filename", filename), SeverityLevel.ERROR);
	}

[scmcca]

Indeed it is recommended for feed_info.txt.

Maybe I'm missing something, but I don't see recommendations for providing the agency.txt or shapes.txt file in the GTFS Best Practices.

[e-lo]

Good call - agency.txt is actually a required file so that should be checked against the spec and shapes.txt inclusion is not a best practice....but should be! (otherwise you are leaving interpretation up to each consuming app).

Updated issue name to be consistent.

[lionel-nj]

agency.txt is actually a required file so that should be checked against the spec

This is the case, @e-lo have you witnessed dataset where agency.txt is missing but the validation report did not flag it?

[e-lo]

This is the case, @e-lo have you witnessed dataset where agency.txt is missing but the validation report did not flag it?

Nope nope! Sorry for false alarm on that one.

[aababilov]

I would introduce a MissingRecommendedFileNotice and also MissingRecommendedFieldNotice with SeverityLevel.WARNING. I generally think that each notice type should have a fixed priority - this is easier to handle in human-readable validation reports and this is easier to setup exceptions for certain feeds that demonstrate errors that we want to skip.

We may add a @Recommended annotation that would work in a similar way to @Required.