Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Best Practice: feed_info should include start_date, end_date, version, email, url (WARNING) #885

Closed
e-lo opened this issue Apr 29, 2021 · 3 comments
Closed

Best Practice: feed_info should include start_date, end_date, version, email, url (WARNING) #885

e-lo opened this issue Apr 29, 2021 · 3 comments
Assignees
@KClough
Labels
good first issue Good task for newcomers to work on. GTFS Best Practices Used for Adding or changing rules that belong in the GTFS Best Practices

Comments

@e-lo
Copy link

e-lo commented Apr 29, 2021

feed_info.txt should Includes valid fields for:

  • feed_start_date, feed_end_date
  • Feed_version.
  • Feed_email
  • feed_url
@e-lo e-lo added the new rule label Apr 29, 2021
@e-lo e-lo changed the title feed_info should include start_date, end_date, version, email, url Best Practice: feed_info should include start_date, end_date, version, email, url (WARNING) Apr 29, 2021
@lionel-nj
Copy link
Contributor

Agreed, as suggested per best practice:

feed_info.txt should be included, with all fields below.

Field Name Recommendation
feed_start_date & feed_end_date Should be included
feed_version Should be included
feed_contact_email & feed_contact_url Provide at least one

https://github.com/MobilityData/GTFS_Schedule_Best-Practices/blob/master/en/feed_info.md

@lionel-nj lionel-nj added GTFS Best Practices Used for Adding or changing rules that belong in the GTFS Best Practices and removed new rule labels Jun 16, 2021
@isabelle-dr isabelle-dr modified the milestones: v3.3.0 - rule improvements, Rule improvements Jan 9, 2022
@isabelle-dr isabelle-dr added the good first issue Good task for newcomers to work on. label Jan 9, 2022
@holly-g holly-g mentioned this issue Apr 26, 2022
Open
2 tasks
@KClough KClough self-assigned this May 6, 2022
KClough added a commit to JarvusInnovations/gtfs-validator that referenced this issue May 16, 2022
@KClough
feat: recommended field annotation MobilityData#885
f704743
KClough added a commit to JarvusInnovations/gtfs-validator that referenced this issue May 16, 2022
@KClough
feat: apply recommended fields to feed_info.txt MobilityData#885
674c9f0
KClough added a commit to JarvusInnovations/gtfs-validator that referenced this issue May 16, 2022
@KClough
feat: recommended field annotation MobilityData#885
3b6b99d
KClough added a commit to JarvusInnovations/gtfs-validator that referenced this issue May 16, 2022
@KClough
feat: apply recommended fields to feed_info.txt MobilityData#885
a80e4ae
@KClough KClough mentioned this issue May 16, 2022
Closed
4 tasks
@maximearmstrong maximearmstrong mentioned this issue May 17, 2022
Merged
3 tasks
KClough added a commit to JarvusInnovations/gtfs-validator that referenced this issue May 18, 2022
@KClough
feat: feed_info recommended fields MobilityData#885
d91d5b0
@KClough KClough mentioned this issue May 18, 2022
Merged
3 tasks
KClough added a commit to JarvusInnovations/gtfs-validator that referenced this issue May 18, 2022
@KClough
feat: recommended field notice MobilityData#885
440a6ae
@KClough KClough mentioned this issue May 18, 2022
Merged
3 tasks
KClough added a commit to JarvusInnovations/gtfs-validator that referenced this issue May 20, 2022
@KClough
feat: feed_info recommended fields MobilityData#885
d0e192c
KClough added a commit that referenced this issue Jun 24, 2022
@KClough
feat: feed_info recommended fields #885
44ef231
KClough added a commit that referenced this issue Jun 24, 2022
@KClough
feat: feed_info recommended fields #885
e6eaf6e
KClough added a commit that referenced this issue Jun 24, 2022
@KClough
feat: feed_info recommended fields #885
8d003d7
KClough added a commit that referenced this issue Jun 24, 2022
@KClough
feat: feed_info recommended fields #885
64bade3
KClough added a commit to JarvusInnovations/gtfs-validator that referenced this issue Jun 29, 2022
@KClough
feat: feed_info recommended fields MobilityData#885
6365a94
KClough added a commit that referenced this issue Jun 29, 2022
@KClough
feat: feed_info recommended fields #885
c6a6f20
maximearmstrong added a commit that referenced this issue Jun 29, 2022
@KClough @maximearmstrong
feat: feed_info should include start_date, end_date, version, email, …
60a6503 
…url (#1156)

* feat: recommended field notice

* chore: apply Jarvus copyright

* Update core/src/main/java/org/mobilitydata/gtfsvalidator/parsing/RowParser.java

Co-authored-by: Maxime Armstrong <46797220+maximearmstrong@users.noreply.github.com>

* test: additional row parser tests

* feat: feed_info recommended fields #885

* docs: Update RULES.md to include feed_info recommended fields

* Update main/src/main/java/org/mobilitydata/gtfsvalidator/table/GtfsFeedInfoSchema.java

Co-authored-by: Maxime Armstrong <46797220+maximearmstrong@users.noreply.github.com>

Co-authored-by: Maxime Armstrong <46797220+maximearmstrong@users.noreply.github.com>
@KClough
Copy link
Collaborator

KClough commented Jul 25, 2022

@isabelle-dr can we mark this issue as closed?

This has been implemented in #1157 , I probably should have put "resolves" instead of "related" in the PR description.

@isabelle-dr
Copy link
Contributor

I think what closes automatically an issue is writing "closes #issue number" in a PR :)

Closing this issue, thanks for adding this to this project!

@takohei takohei mentioned this issue May 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KClough KClough

Labels
good first issue Good task for newcomers to work on. GTFS Best Practices Used for Adding or changing rules that belong in the GTFS Best Practices
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: recommended field annotation MobilityData/gtfs-validator
4 participants
@KClough @e-lo @lionel-nj @isabelle-dr