-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added features document. Some corrections to components presence #1662
feat: Added features document. Some corrections to components presence #1662
Conversation
…n component names. Refactored a bit.
✅ Rule acceptance tests passed. |
@qcdyx I made some changes in the code that you could review. You don't need to review the markdown file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jcpitre This looks good! I think it would be good to link to the public GTFS components document in the "list of components" text at the top.
docs/features.md
Outdated
|
||
The validator will list the list of components that it finds in the processed feed according to this table: | ||
|
||
| Component | Feature | How is the presence of a featuree determined (minimum requirements) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: featuree should be feature
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Repaired
|
It's being used in public facing meetings, so we can go ahead and add it. It's important context for anyone who reads the documentation and doesn't know what components are. |
✅ Rule acceptance tests passed. |
Added the link |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary:
Closes #1661
Added a document with the list of components-features and how we determine if they are present.
Removed Blocks component
Corrected the code where components were duplicated because of a typo in their name,
Expected behavior:
I expect no change of behavior.
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle test
to make sure you didn't break anything