Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 1758 flex investigate integration of geojson files #1784

Closed

Conversation

qcdyx
Copy link
Contributor

@qcdyx qcdyx commented Jul 15, 2024

Summary:

Closes #1758

Expected behavior:
This is not a production ready PR - this is to prove that we can use GeoTools to read in location.geojson file in the validator.

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@qcdyx qcdyx linked an issue Jul 15, 2024 that may be closed by this pull request
Copy link
Contributor

This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: ./gradlew goJF.

@davidgamez davidgamez added the do not merge This PR needs more work/discussion or is not meant to be merged label Jul 15, 2024
Copy link
Contributor

📝 Acceptance Test Report

📋 Summary

✅ The rule acceptance has passed for commit 572a519
Download the full acceptance test report here (report will disappear after 90 days).

📊 Notices Comparison

New Errors (0 out of 1527 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Errors (0 out of 1527 datasets, ~0%) ✅

No changes were detected due to the code change.

New Warnings (0 out of 1527 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Warnings (0 out of 1527 datasets, ~0%) ✅

No changes were detected due to the code change.

🛡️ Corruption Check

0 out of 1527 sources (~0 %) are corrupted.

⏱️ Performance Assessment

📈 Validation Time

Assess the performance in terms of seconds taken for the validation process.

Time Metric Dataset ID Reference (s) Latest (s) Difference (s)
Average -- 3.88 3.99 ⬆️+0.11
Median -- 1.36 1.45 ⬆️+0.09
Standard Deviation -- 10.99 11.02 ⬆️+0.03
Minimum in References Reports us-oregon-hut-airport-shuttle-gtfs-635 0.51 0.60 ⬆️+0.09
Maximum in Reference Reports gb-unknown-uk-aggregate-feed-gtfs-2014 301.77 301.77 ⬆️+0.00
Minimum in Latest Reports us-california-flex-v2-developer-test-feed-3-gtfs-1819 0.52 0.56 ⬆️+0.03
Maximum in Latest Reports gb-unknown-uk-aggregate-feed-gtfs-2014 301.77 301.77 ⬆️+0.00

@davidgamez
Copy link
Member

Thanks @qcdyx , I'm closing this PR as it's intended for demonstration purposes. The addition of the location.geojson will be addressed in #1750

@davidgamez davidgamez closed this Jul 16, 2024
@qcdyx qcdyx deleted the 1758-flex-investigate-integration-of-geojson-files branch August 28, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge This PR needs more work/discussion or is not meant to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flex: Investigate integration of geojson files
2 participants