Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #515 #522

Merged
merged 2 commits into from
Mar 22, 2024
Merged

Issue #515 #522

merged 2 commits into from
Mar 22, 2024

Conversation

rimjhimittal
Copy link
Contributor

@pgleeson
Copy link
Member

@rimjhimittal It's good practice to open PRs just to fix one issue at a time. There are changes in here too for the fix related to onnx.py, so best take these out.
Also make sure your code is black formatted before you commit, see https://mdf.readthedocs.io/en/latest/api/Contributing.html#step-7

@pgleeson
Copy link
Member

Also make sure you pull in the latest changes from the main mdf development branch, as there have been a few changes there in the past few days.

@rimjhimittal rimjhimittal reopened this Mar 21, 2024
@rimjhimittal
Copy link
Contributor Author

@pgleeson Alright Padraig, Thanks. I'll take care of that from now on.

@pgleeson pgleeson merged commit 04b0084 into ModECI:development Mar 22, 2024
11 checks passed
@pgleeson
Copy link
Member

Thanks @rimjhimittal!

@rimjhimittal rimjhimittal deleted the issue-515 branch March 23, 2024 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants