Skip to content

Generate and add contributors to documentation #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 10, 2023

Conversation

Onoyiza
Copy link
Contributor

@Onoyiza Onoyiza commented Jul 5, 2023

Hi @pgleeson. I have added the contributors to modelspec documentation.
The changes are:

  1. There are two new files (contributors.py and Contributors.md). The contributors.py file generates "Contributors.md".
  2. A modified "index.rst" to include contributors in the content of the documentation.

I look forward to your feedback.
Thank you.

@pgleeson
Copy link
Member

pgleeson commented Jul 5, 2023

Thanks @Onoyiza. Can you add a step in this repo too in the github actions script for generating the documentation, preceeded by running generate.py and contributors.py? Thanks!

@pgleeson
Copy link
Member

pgleeson commented Jul 5, 2023

Also, maybe in a separate branch, can you add tests for windows and mac too, as in the mdf test script?

@Onoyiza
Copy link
Contributor Author

Onoyiza commented Jul 5, 2023

Thanks @Onoyiza. Can you add a step in this repo too in the github actions script for generating the documentation, preceeded by running generate.py and contributors.py? Thanks!

Yes, I can. Thank you!

@Onoyiza
Copy link
Contributor Author

Onoyiza commented Jul 5, 2023

Also, maybe in a separate branch, can you add tests for windows and mac too, as in the mdf test script?

Hi @pgleeson.

I have tried to do this but the test fails on one python version for the mac OS but after I ran the failed job twice it worked.

https://github.com/Onoyiza/modelspec/actions

@pgleeson pgleeson merged commit 2baef9d into ModECI:development Jul 10, 2023
@pgleeson
Copy link
Member

Looks good, thanks! Please merge the latest from development into your other branch with win/mac etc. open a pull request and we can discuss issues there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants