Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RaceMenuPresets to possible data folders #31

Merged
merged 2 commits into from
Jun 2, 2024

Conversation

Twinki14
Copy link
Contributor

@Twinki14 Twinki14 commented May 26, 2024

Motivations

Modifications

  • Add RaceMenuPresets to the list of possible data folder names
  • Run clang-format against the header file

# Motivations
- `Root` is a data directory used by the popular Root Builder plugin https://kezyma.github.io/?p=rootbuilder
- `RaceMenuPresets` is a data directory used by a popular mod for FNV Character Preset Menu https://www.nexusmods.com/newvegas/mods/72789

Both these additions have been requested in the FNV modding community

# Modifications
- Add `Root` and `RaceMenuPresets to the list of possible data folder names
- Run clang-format against the header file
@Holt59
Copy link
Member

Holt59 commented May 27, 2024

This applies to both PR but I don't really like the idea of adding Root as a valid data folder since this comes from a plugin. I think this was already discussed on Discord some times ago.

A better way would be to allow non-game plugins to add extra way to make data valid. That's not a huge amount of work in the end so I might take a look at it.

@Twinki14
Copy link
Contributor Author

Twinki14 commented May 27, 2024

This applies to both PR but I don't really like the idea of adding Root as a valid data folder since this comes from a plugin. I think this was already discussed on Discord some times ago.

A better way would be to allow non-game plugins to add extra way to make data valid. That's not a huge amount of work in the end so I might take a look at it.

I could spend time looking into this, I may have the spare time to get it done quite quickly. Any chance you could point me in the right direction? I'm unfamiliar with any nom-game plugin code (Unless you're already on it)

EDIT: It looks like Mod Organizer 2 non-game plugins are all done in Python, I don't know much about Python and I'd be curious to know how the Mod Organizer 2 C++ core is wired up to allow for modification via Python based plugins.

@Holt59
Copy link
Member

Holt59 commented May 27, 2024

This applies to both PR but I don't really like the idea of adding Root as a valid data folder since this comes from a plugin. I think this was already discussed on Discord some times ago.
A better way would be to allow non-game plugins to add extra way to make data valid. That's not a huge amount of work in the end so I might take a look at it.

I could spend time looking into this, I may have the spare time to get it done quite quickly. Any chance you could point me in the right direction? I'm unfamiliar with any nom-game plugin code (Unless you're already on it)

EDIT: It looks like Mod Organizer 2 non-game plugins are all done in Python, I don't know much about Python and I'd be curious to know how the Mod Organizer 2 C++ core is wired up to allow for modification via Python based plugins.

I have my idea on how to do that but I want to target larger thing than just allowing plugin to make data valid, so that will require a lot of changes (simple changes, but still). I'll try to have a look at it this week.

@AnyOldName3
Copy link
Member

EDIT: It looks like Mod Organizer 2 non-game plugins are all done in Python

Most of MO2 itself is plugins, and barely any of them are Python.

I don't know much about Python and I'd be curious to know how the Mod Organizer 2 C++ core is wired up to allow for modification via Python based plugins.

https://github.com/ModOrganizer2/modorganizer-plugin_python is a C++ plugin that makes it possible for plugins to be implemented in Python.

@Twinki14 Twinki14 changed the title Add Root and RaceMenuPresets to possible data folders Add RaceMenuPresets to possible data folders Jun 1, 2024
@Twinki14
Copy link
Contributor Author

Twinki14 commented Jun 1, 2024

This PR is updated & ready, I've removed the addition of Root

@Holt59 Holt59 merged commit 02d8624 into ModOrganizer2:master Jun 2, 2024
2 checks passed
@Twinki14 Twinki14 deleted the tweak-valid-data-dirs branch June 2, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants