Use UIBase utility to open file.

ModOrganizer2 · Aug 9, 2024 · baa508a · baa508a
1 parent 24bcc78
commit baa508a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 15 deletions.
diff --git a/src/installer_manual_en.ts b/src/installer_manual_en.ts
@@ -151,7 +151,7 @@ p, li { white-space: pre-wrap; }
 <context>
     <name>InstallerManual</name>
     <message>
-        <location filename="installermanual.cpp" line="52"/>
+        <location filename="installermanual.cpp" line="50"/>
         <source>Manual Installer</source>
         <translation type="unfinished"></translation>
     </message>

diff --git a/src/installermanual.cpp b/src/installermanual.cpp
@@ -22,8 +22,6 @@ along with Mod Organizer.  If not, see <http://www.gnu.org/licenses/>.
 #include <QDialog>
 #include <QtPlugin>
 
-#include <Shellapi.h>
-
 #include <uibase/game_features/igamefeatures.h>
 #include <uibase/game_features/moddatachecker.h>
 #include <uibase/iinstallationmanager.h>
@@ -75,18 +73,7 @@ bool InstallerManual::isArchiveSupported(std::shared_ptr<const MOBase::IFileTree
 void InstallerManual::openFile(const FileTreeEntry* entry)
 {
   QString tempName = manager()->extractFile(entry->shared_from_this());
-
-  SHELLEXECUTEINFOW execInfo;
-  memset(&execInfo, 0, sizeof(SHELLEXECUTEINFOW));
-  execInfo.cbSize        = sizeof(SHELLEXECUTEINFOW);
-  execInfo.fMask         = SEE_MASK_NOCLOSEPROCESS;
-  execInfo.lpVerb        = L"open";
-  std::wstring fileNameW = ToWString(tempName);
-  execInfo.lpFile        = fileNameW.c_str();
-  execInfo.nShow         = SW_SHOWNORMAL;
-  if (!::ShellExecuteExW(&execInfo)) {
-    qCritical("failed to spawn %s: %d", qUtf8Printable(tempName), ::GetLastError());
-  }
+  shell::Open(tempName);
 }
 
 IPluginInstaller::EInstallResult