Release 2.1.4 #454
Merged
Release 2.1.4 #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t non-release builds are possible and get labelled as such
Better version parsing
Move improved version parsing to util.h and use it everywhere.
…sed by the fileSystemWatcher picking up changes made by MO itself and triggering multiple refreshes
…tcher triggered refreshes. Avoid app freezes caused by stacked refresh calls. Added chack to see if a download is alerady hidden before trying to hide it. Made sure to refresh Download tab where it was othwerwise relying in the dirwatcher to refresh.
Downloads tab: fix for freezes and greatly improved performance and responsiveness
updateToolBar was creating new QActions and QWidgets every call, without cleaning them up. The spacer, help widgets, and toolbuttons only need to be created once. Those have been moved out into the MainWindow constructor updateToolBar is called in various places, importantly when adding/removing executable shortcuts. Also adds a deleteLater() call to clean up executable shortcut actions.
Fix a memory leak in updateToolBar
Improved performace when hiding/unhiding. There is still room for improvement for hiding but it requires refactoring the function
*Added "Visit on Nexus" menu entry in the downloads tab. *Added confirmation message when deleting a single download. *Changed text of messages to more easily distinguish deleting from hiding.
Windows directories are not allowed to end in a space. Allowing this creates a broken directory that is difficult for the user to remove.
Sort by game and fix for instance names
…idth for them to procede. Now they will instead remain in the download state and continue once the bandwidth is available. There is much room for improvement here but for now I guess this will avoid MO simply stopping the download.
Extend mod backups and load order backups to a maximum of 10
Disabled timer check as it appeared to terminate some downloads early.
…king confirmation.
…his will need to be reversted once the Bsa changes are added I presume.
Improved downloads tab header sizes and resize policy.
…w before it wouldn't work.
At times, the voted_by_user item is returned as Invalid. toBool() causes this to be false, meaning the item is seen as not endorsed. Now, the endorsement state is not checked if the data is invalid.
Previously allowed: "A-Za-z0-9 "
Now allowed: "A-Za-z0-9 !@#$%^()_+-=[]{};'."
This allows the register dialog to appear when the user had previously selected "No, don't ask again". If a user is clicking this button, there's a good chance they want MO to be the primary nxm handler.
This was referenced Jul 29, 2018
… view. this will need to be reversted once the Bsa changes are added I presume." This reverts commit 8f28e0a.
…ne used it before and now it's much more practical.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Push to master for Main Release and Tagging.
The following to be done.