-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSON.stringify correctness issue #112
Comments
Another one:
|
Thank you much for the report. I committed a fix which should be published next week. Meanwhile xst 8.6.2 is available so you can test with eshost. |
peterwmwong
pushed a commit
to peterwmwong/v8
that referenced
this issue
Jan 7, 2019
The reference implementation used in the tests does not fully match the spec, so for the diverging cases we need to explicitly specify the correct expectation. Every single change in this patch has been verified against every major JavaScript engine using eshost + jsvu. All implementations match the spec (and the V8 implementation), with the following two exceptions: - One expectation was wrong because of a JavaScriptCore bug (that is, we inherited the incorrect expectation when importing the tests from WebKit). A comment was added for that one. - This work resulted in the discovery of bugs in Moddable/XS: Moddable-OpenSource/moddable#112 Change-Id: I05d91d7acc5c8765e941fcd68c1086c2694c710c Reviewed-on: https://chromium-review.googlesource.com/c/1396081 Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#58546}
mkellner
pushed a commit
that referenced
this issue
Jan 7, 2019
mkellner
pushed a commit
that referenced
this issue
Jan 29, 2019
The fix is now committed. |
mkellner
pushed a commit
that referenced
this issue
Feb 14, 2019
mkellner
pushed a commit
that referenced
this issue
Feb 21, 2019
mkellner
pushed a commit
that referenced
this issue
Mar 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The text was updated successfully, but these errors were encountered: