The default value of the “manifest” property does not work when including Git repositories.

[stc1988]

Build environment: macOS
Moddable SDK version: 5.11.0
Target device: Moddable Two

Steps to Reproduce

Make the following changes to the manifest.json to build and install the app examples/io/audioin/levelmonitor.　This is a modification to use unit mini pdm as a microphone.

"include": [
	"$(MODDABLE)/examples/manifest_base.json",
	"$(MODDABLE)/modules/io/manifest.json",
	"$(MODDABLE)/modules/io/audioin/manifest.json",
    // add below object
	{
		"git": "https://github.com/stc1988/moddable-unit_mini_pdm.git"
	}
],

Expected behavior

I exepect that app includes https://github.com/stc1988/moddable-unit_mini_pdm/blob/main/manifest.json, but it’s not working.

On the other hand, when written as follows, it works as expected.

		{
			"git": "https://github.com/stc1988/moddable-unit_mini_pdm.git",
			"manifest": "manifest.json"
		}

In the documentation, it says, “The default value of the ‘manifest’ property is ‘manifest.json’.” So is there a misunderstanding on my part?

[phoddie]

Your understanding is correct. There's a error handling the default, probably introduced during evolution of the feature. In mcmanifest.js change...

let { git, branch, tag, manifest = [ "manifest.json" ] } = it;

...to...

let { git, branch, tag, manifest = "manifest.json" } = it;

Please remember to rebuild tools after making the change.

[stc1988]

let { git, branch, tag, manifest = "manifest.json" } = it;

This change got this issue fixed. Thank you.

[phoddie]

Excellent. Thank you for the quick confirmation (and original report). We'll get that change into the next SDK release.