Skip to content

Conversation

@rwaldron
Copy link
Contributor

Smoke tested with:

  • examples/drivers/BMP180
  • examples/drivers/lis3dh
  • examples/drivers/mcp23008 (existing and new feature branch)
  • examples/drivers/mcp23017

@rwaldron rwaldron requested review from mkellner and phoddie December 12, 2017 15:59
@phoddie
Copy link
Collaborator

phoddie commented Dec 12, 2017

Tnanks, looks good. I believe examples/drivers/HMC5883L/main.js needs to be updated in the call to the SMBus constructor. Additionally, it would be good to update the I2C constructor docs in pins.md.

Smoke tested with:

- examples/drivers/BMP180
- examples/drivers/HMC5883L
- examples/drivers/lis3dh
- examples/drivers/mcp23008 (existing and new feature branch)
- examples/drivers/mcp23017 (on new feature branch)
I created these while testing the examples and thought it might benefit others to share them.
@rwaldron
Copy link
Contributor Author

@phoddie updated!

@phoddie
Copy link
Collaborator

phoddie commented Dec 14, 2017

Looks great. We'll get these merged (Big thanks for the two manifests - I haven't had a chance to dig those components out recently to put those together)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants