Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i2c.c: rename "clock" => "scl" (+ modSsd1306.c). Fixes gh-14 #17

Closed
wants to merge 320 commits into from

Conversation

rwaldron
Copy link
Contributor

Smoke tested with:

  • examples/drivers/BMP180
  • examples/drivers/lis3dh
  • examples/drivers/mcp23008 (existing and new feature branch)
  • examples/drivers/mcp23017

@phoddie
Copy link
Collaborator

phoddie commented Dec 12, 2017

Tnanks, looks good. I believe examples/drivers/HMC5883L/main.js needs to be updated in the call to the SMBus constructor. Additionally, it would be good to update the I2C constructor docs in pins.md.

Smoke tested with:

- examples/drivers/BMP180
- examples/drivers/HMC5883L
- examples/drivers/lis3dh
- examples/drivers/mcp23008 (existing and new feature branch)
- examples/drivers/mcp23017 (on new feature branch)
I created these while testing the examples and thought it might benefit others to share them.
@rwaldron
Copy link
Contributor Author

@phoddie updated!

@phoddie
Copy link
Collaborator

phoddie commented Dec 14, 2017

Looks great. We'll get these merged (Big thanks for the two manifests - I haven't had a chance to dig those components out recently to put those together)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants