linux CLI platform (for agoric-sdk builds) #305
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 27, 2019
Closed
Signed-off-by: Dan Connolly <dckc@madmode.com>
use "mcconfig -p x-cli-lin" to build it Signed-off-by: Dan Connolly <dckc@madmode.com>
If the headersComplete callback returns 'upgrade', return from the server callback immediately rather than continuing to the prepareResponse callback.
websockets.js doesn't check socket.write() to see how much data it can send. The agoric pixel demo goes over 1k, so let's use 4k for now.
- set promiseJobsFlag in fxQueuePromiseJobs
This lets the lin_xs_cli platform run the promise queue to quiescence,
a technique taken from xsl.
- exit when promise from main() resolves
- exit with failure if main() promise is rejected
- fix hang in delete machine: don't unref main context
- keep main loop running while promise jobs are pending
- never mind then() process
If the headersComplete callback returns 'upgrade', return from the server callback immediately rather than continuing to the prepareResponse callback.
websockets.js doesn't check socket.write() to see how much data it can send. The agoric pixel demo goes over 1k, so let's use 4k for now.
It seems to not work in some cases and fxPromiseIsPending does it better anyway.
We plan to use git submodule integration into agoric-sdk.
The ISSUE of why do headless builds fail without debug tools? seems to have gone away.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to my earlier 2 PRs:
This adds
Perhaps the github build action is too Agoric-specific? @dtribble has encouraged me to get everything that Agoric needs upstreamed, though. And for our purposes, it's at least cost-effective, if not critical.
Agoric/agoric-sdk#118 (comment)
chat with @dtribble...