[FIX] Padding infeatures/outfeatures for exllama, exllama v2, and marlin #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Confirmed my suspicion that padding code will impact the shape of saved tensors to disk. Pack has been fixed so that the saved size is correct (original) but now running into load issues since the expanded/padded buffers are now larger than the tensors on disk so accelerate is throwing shape not same errors during qunt model load. We will explore 2 methods to deal with this tomorrow.
|
…size in post_init
|
Update: We are going with Plan B. |
DeJoker
pushed a commit
to DeJoker/GPTQModel
that referenced
this pull request
Jul 19, 2024
…lin (ModelCloud#98) * fix padding * fix padding * store original in/out features * fix bad var reference * shorter var name * limit bitblas convert to use 1 thread * ruff * fix qlinear_exllama pack * revert qliner_marlin change * cleanup code * plan b: init with original shape, then model load, then do padding/resize in post_init * fix g_idx post_init * const var reformat to all caps * fix ( -> [ * padding the x that passes in forward * comments/todo * comments --------- Co-authored-by: LRL-ModelCloud <lrl@modelcloud.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #100