[fel] Add close support in McpClient and release resources properly #144
+38
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added Closeable interface to McpClient to support proper resource cleanup. - Implemented close() method in DefaultMcpClient to: - Cancel SSE subscription. - Shutdown ping scheduler gracefully. - Log client closure with context. - Added /close endpoint in TestController for testing purposes to trigger client shutdown via HTTP. This change ensures that the MCP client releases all held resources when no longer needed, improving reliability and preventing leaks.
CodeCasterX
added
type: enhancement
Yager-42
pushed a commit
to Yager-42/fit-framework
that referenced
this pull request
Aug 16, 2025
…odelEngine-Group#144) - Added Closeable interface to McpClient to support proper resource cleanup. - Implemented close() method in DefaultMcpClient to: - Cancel SSE subscription. - Shutdown ping scheduler gracefully. - Log client closure with context. - Added /close endpoint in TestController for testing purposes to trigger client shutdown via HTTP. This change ensures that the MCP client releases all held resources when no longer needed, improving reliability and preventing leaks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures that the MCP client releases all held resources when no longer needed, improving reliability and preventing leaks.