Skip to content

Conversation

@surpercodehang
Copy link
Contributor

@surpercodehang surpercodehang commented Jul 12, 2025

🔗 相关问题 / Related Issue

工具的schema不符合规范:/ The schema of the tool does not conform to the specification:

  • examples应该是个数组 / examples should be an array
  • object中的required应该是个数组 / required in object should be an array

Issue 链接 / Issue Link: #200

  • 我已经创建了相关 Issue 并进行了讨论 / I have created and discussed the related issue
  • 这是一个微小的修改(如错别字),不需要 Issue / This is a trivial change (like typo fix) that doesn't need an issue

📋 变更类型 / Type of Change

  • 🐛 Bug 修复 / Bug fix (non-breaking change which fixes an issue)
  • ✨ 新功能 / New feature (non-breaking change which adds functionality)
  • 💥 破坏性变更 / Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 文档更新 / Documentation update
  • 🔧 重构 / Refactoring (no functional changes)
  • ⚡ 性能优化 / Performance improvement
  • 🧹 代码清理 / Code cleanup

📝 变更目的 / Purpose of the Change

规范工具生成的 json schema 逻辑,适配 mcp 协议 / Standardize the json schema logic generated by the tool to adapt to the mcp protocol

📋 主要变更 / Brief Changelog

  • examples 字段更改为 example / Changed the examples field to example
  • object 类型下的新增 required 数组 / Added required array under object type
  • 去掉 required 字段类型为 bool 的数据 / Removed data with bool type in required field

🧪 验证变更 / Verifying this Change

测试步骤 / Test Steps

  1. 基本单测通过 / Basic unit test passed
  2. schema 数据接入 mcp 服务可以注册调用 / Schema data access mcp service can be registered and called

测试覆盖 / Test Coverage

  • 我已经添加了单元测试 / I have added unit tests
  • 所有现有测试都通过 / All existing tests pass
  • 我已经进行了手动测试 / I have performed manual testing

📸 截图 / Screenshots

✅ 贡献者检查清单 / Contributor Checklist

请确保你的 Pull Request 符合以下要求 / Please ensure your Pull Request meets the following requirements:

基本要求 / Basic Requirements:

  • 确保有 GitHub Issue 对应这个变更(微小变更如错别字除外)/ Make sure there is a Github issue filed for the change (trivial changes like typos excluded)
  • 你的 Pull Request 只解决一个 Issue,没有包含其他不相关的变更 / Your PR addresses just this issue, without pulling in other changes - one PR resolves one issue
  • PR 中的每个 commit 都有有意义的主题行和描述 / Each commit in the PR has a meaningful subject line and body

代码质量 / Code Quality:

  • 我的代码遵循项目的代码规范 / My code follows the project's coding standards
  • 我已经进行了自我代码审查 / I have performed a self-review of my code
  • 我已经为复杂的代码添加了必要的注释 / I have commented my code, particularly in hard-to-understand areas

测试要求 / Testing Requirements:

  • 我已经编写了必要的单元测试来验证逻辑正确性 / I have written necessary unit-tests to verify the logic correction
  • 当存在跨模块依赖时,我尽量使用了 mock / I have used mocks when cross-module dependencies exist
  • 基础检查通过:mvn -B clean package -Dmaven.test.skip=true,elsa README 中的编译检查 / Basic checks pass
  • 单元测试通过:mvn clean install / Unit tests pass

文档和兼容性 / Documentation and Compatibility:

  • 我已经更新了相应的文档 / I have made corresponding changes to the documentation
  • 如果有破坏性变更,我已经在 PR 描述中详细说明 / If there are breaking changes, I have documented them in detail
  • 我已经考虑了向后兼容性 / I have considered backward compatibility

📋 附加信息 / Additional Notes


审查者注意事项 / Reviewer Notes:

@surpercodehang surpercodehang added this to the 3.5.x milestone Jul 12, 2025
@surpercodehang surpercodehang self-assigned this Jul 12, 2025
@surpercodehang surpercodehang added the type: enhancement A general enhancement label Jul 12, 2025
@surpercodehang surpercodehang moved this to In review in Nova Jul 12, 2025
@surpercodehang surpercodehang linked an issue Jul 12, 2025 that may be closed by this pull request
4 tasks
@surpercodehang surpercodehang changed the title [tool] 升级 tool 编译工具适配 mcp 工具模式 [tool] Upgrade tool compilation tool to adapt to mcp tool mode Jul 12, 2025
@surpercodehang surpercodehang requested a review from loveTsong July 12, 2025 09:27
returnPropertyEntity.setType(jsonNode.get("type").asText());
returnPropertyEntity.setItems(null);
returnPropertyEntity.setProperties(null);
returnPropertyEntity.setRequired(null);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

这里的设置null是不是没有用的呢?

@CodeCasterX CodeCasterX added the in: fel Issues in FEL(FIT Expression for LLM) modules label Jul 13, 2025
@CodeCasterX CodeCasterX modified the milestones: 3.5.x, 3.5.0 Jul 13, 2025
CodeCasterX
CodeCasterX previously approved these changes Jul 14, 2025
@surpercodehang surpercodehang changed the base branch from main to 3.5.x July 14, 2025 03:29
@surpercodehang surpercodehang dismissed CodeCasterX’s stale review July 14, 2025 03:29

The base branch was changed.

@CodeCasterX CodeCasterX merged commit 87b73a5 into ModelEngine-Group:3.5.x Jul 14, 2025
1 check passed
@github-project-automation github-project-automation bot moved this from In review to Done in Nova Jul 14, 2025
Yager-42 pushed a commit to Yager-42/fit-framework that referenced this pull request Aug 16, 2025
surpercodehang added a commit to surpercodehang/fit-framework that referenced this pull request Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: fel Issues in FEL(FIT Expression for LLM) modules type: enhancement A general enhancement

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

工具的schema不符合规范

2 participants