Skip to content

Conversation

@FredGoo
Copy link
Contributor

@FredGoo FredGoo commented Jul 17, 2025

🔗 相关问题 / Related Issue

Issue 链接 / Issue Link: #94

  • 我已经创建了相关 Issue 并进行了讨论 / I have created and discussed the related issue
  • 这是一个微小的修改(如错别字),不需要 Issue / This is a trivial change (like typo fix) that doesn't need an issue

📋 变更类型 / Type of Change

  • 🐛 Bug 修复 / Bug fix (non-breaking change which fixes an issue)
  • ✨ 新功能 / New feature (non-breaking change which adds functionality)
  • 💥 破坏性变更 / Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 文档更新 / Documentation update
  • 🔧 重构 / Refactoring (no functional changes)
  • ⚡ 性能优化 / Performance improvement
  • 🧹 代码清理 / Code cleanup

📝 变更目的 / Purpose of the Change

Starting with Python 3.8, macOS uses the spawn method by default, identical to Windows.
The previous while True + Process respawn loop is therefore unnecessary on macOS.
This change unifies the startup behavior between Windows and macOS, keeping the auto-restart guard only on Linux, and eliminates redundant processes and log noise for macOS users.

📋 主要变更 / Brief Changelog

  • Extended platform check from platform.system() == 'Windows' to platform.system() in ('Windows', 'Darwin').
  • macOS now calls main() once and exits, matching Windows behavior.
  • Linux retains the existing while True + Process respawn logic.

🧪 验证变更 / Verifying this Change

测试步骤 / Test Steps

  1. Run the entry script on Windows → observe one main() invocation, then exit.
  2. Run the entry script on macOS → same single invocation, no respawn loop.
  3. Run the entry script on Linux → main() is started inside a child process; upon exit it is automatically restarted (confirm via logs or ps).

测试覆盖 / Test Coverage

  • 我已经添加了单元测试 / I have added unit tests
  • 所有现有测试都通过 / All existing tests pass
  • 我已经进行了手动测试 / I have performed manual testing

📸 截图 / Screenshots

✅ 贡献者检查清单 / Contributor Checklist

请确保你的 Pull Request 符合以下要求 / Please ensure your Pull Request meets the following requirements:

基本要求 / Basic Requirements:

  • 确保有 GitHub Issue 对应这个变更(微小变更如错别字除外)/ Make sure there is a Github issue filed for the change (trivial changes like typos excluded)
  • 你的 Pull Request 只解决一个 Issue,没有包含其他不相关的变更 / Your PR addresses just this issue, without pulling in other changes - one PR resolves one issue
  • PR 中的每个 commit 都有有意义的主题行和描述 / Each commit in the PR has a meaningful subject line and body

代码质量 / Code Quality:

  • 我的代码遵循项目的代码规范 / My code follows the project's coding standards
  • 我已经进行了自我代码审查 / I have performed a self-review of my code
  • 我已经为复杂的代码添加了必要的注释 / I have commented my code, particularly in hard-to-understand areas

测试要求 / Testing Requirements:

  • 我已经编写了必要的单元测试来验证逻辑正确性 / I have written necessary unit-tests to verify the logic correction
  • 当存在跨模块依赖时,我尽量使用了 mock / I have used mocks when cross-module dependencies exist
  • 基础检查通过:mvn -B clean package -Dmaven.test.skip=true,elsa README 中的编译检查 / Basic checks pass
  • 单元测试通过:mvn clean install / Unit tests pass

文档和兼容性 / Documentation and Compatibility:

  • 我已经更新了相应的文档 / I have made corresponding changes to the documentation
  • 如果有破坏性变更,我已经在 PR 描述中详细说明 / If there are breaking changes, I have documented them in detail
  • 我已经考虑了向后兼容性 / I have considered backward compatibility

📋 附加信息 / Additional Notes


审查者注意事项 / Reviewer Notes:

@CodeCasterX CodeCasterX linked an issue Jul 18, 2025 that may be closed by this pull request
@CodeCasterX CodeCasterX self-requested a review July 18, 2025 01:40
@CodeCasterX CodeCasterX added type: bug A general bug in: fit Issues in FIT modules labels Jul 18, 2025
@CodeCasterX CodeCasterX added this to Nova Jul 18, 2025
@CodeCasterX CodeCasterX added this to the 3.5.0 milestone Jul 18, 2025
@CodeCasterX CodeCasterX removed this from Nova Jul 18, 2025
CodeCasterX
CodeCasterX previously approved these changes Jul 18, 2025
@CodeCasterX CodeCasterX changed the base branch from main to 3.5.x July 18, 2025 01:42
@CodeCasterX CodeCasterX dismissed their stale review July 18, 2025 01:42

The base branch was changed.

@FredGoo FredGoo force-pushed the fit-bugfix-python-macos branch from 8474833 to 3b292ad Compare July 18, 2025 02:03
@FredGoo FredGoo force-pushed the fit-bugfix-python-macos branch from 3b292ad to f8c66dc Compare July 18, 2025 02:05
@CodeCasterX CodeCasterX merged commit f4602b6 into ModelEngine-Group:3.5.x Jul 21, 2025
1 check failed
@FredGoo FredGoo deleted the fit-bugfix-python-macos branch August 14, 2025 16:04
surpercodehang pushed a commit to surpercodehang/fit-framework that referenced this pull request Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: fit Issues in FIT modules type: bug A general bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FIT for Python 无法在 MacOS 上运行

2 participants