Skip to content

Conversation

@surpercodehang
Copy link
Contributor

@surpercodehang surpercodehang commented Jul 23, 2025

🔗 相关问题 / Related Issue

原先逻辑是在心跳重新连接并恢复后注册 fitable 信息到注册中心,但是在验证的过程中,还是会发现因为网络或者注册中心未及时启动导致 python 进程注册失败,导致未成功注册信息到注册中心,因此修改为每次心跳注册 fitable 信息到注册中心。 / The original logic was to register the fitable information to the registration center after the heartbeat was reconnected and restored. However, during the verification process, it was found that the python process registration failed because the network or the registration center was not started in time, resulting in unsuccessful registration of the information to the registration center. Therefore, it was changed to register the fitable information to the registration center for each heartbeat.

Issue 链接 / Issue Link: #

  • 我已经创建了相关 Issue 并进行了讨论 / I have created and discussed the related issue
  • 这是一个微小的修改(如错别字),不需要 Issue / This is a trivial change (like typo fix) that doesn't need an issue

📋 变更类型 / Type of Change

  • 🐛 Bug 修复 / Bug fix (non-breaking change which fixes an issue)
  • ✨ 新功能 / New feature (non-breaking change which adds functionality)
  • 💥 破坏性变更 / Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 文档更新 / Documentation update
  • 🔧 重构 / Refactoring (no functional changes)
  • ⚡ 性能优化 / Performance improvement
  • 📦 依赖升级 / Dependency upgrade (update dependencies to newer versions)
  • 🚀 功能增强 / Feature enhancement (improve existing functionality without breaking changes)
  • 🧹 代码清理 / Code cleanup

📝 变更目的 / Purpose of the Change

避免偶然出现的 fitable 调用失败 / Avoid occasional fitable call failures

📋 主要变更 / Brief Changelog

  • 将心跳连接成功之后重新注册更改为每次心跳都会注册 / Change re-registration after successful heartbeat connection to registration for each heartbeat

🧪 验证变更 / Verifying this Change

测试步骤 / Test Steps

  1. 在系统环境上长时间测试,未发现fitable调用找不到服务 / Long-term testing in the system environment did not find the fitable call could not find the service

测试覆盖 / Test Coverage

  • 我已经添加了单元测试 / I have added unit tests
  • 所有现有测试都通过 / All existing tests pass
  • 我已经进行了手动测试 / I have performed manual testing

📸 截图 / Screenshots

✅ 贡献者检查清单 / Contributor Checklist

请确保你的 Pull Request 符合以下要求 / Please ensure your Pull Request meets the following requirements:

基本要求 / Basic Requirements:

  • 确保有 GitHub Issue 对应这个变更(微小变更如错别字除外)/ Make sure there is a Github issue filed for the change (trivial changes like typos excluded)
  • 你的 Pull Request 只解决一个 Issue,没有包含其他不相关的变更 / Your PR addresses just this issue, without pulling in other changes - one PR resolves one issue
  • PR 中的每个 commit 都有有意义的主题行和描述 / Each commit in the PR has a meaningful subject line and body

代码质量 / Code Quality:

  • 我的代码遵循项目的代码规范 / My code follows the project's coding standards
  • 我已经进行了自我代码审查 / I have performed a self-review of my code
  • 我已经为复杂的代码添加了必要的注释 / I have commented my code, particularly in hard-to-understand areas

测试要求 / Testing Requirements:

  • 我已经编写了必要的单元测试来验证逻辑正确性 / I have written necessary unit-tests to verify the logic correction
  • 当存在跨模块依赖时,我尽量使用了 mock / I have used mocks when cross-module dependencies exist
  • 基础检查通过:mvn -B clean package -Dmaven.test.skip=true,elsa README 中的编译检查 / Basic checks pass
  • 单元测试通过:mvn clean install / Unit tests pass

文档和兼容性 / Documentation and Compatibility:

  • 我已经更新了相应的文档 / I have made corresponding changes to the documentation
  • 如果有破坏性变更,我已经在 PR 描述中详细说明 / If there are breaking changes, I have documented them in detail
  • 我已经考虑了向后兼容性 / I have considered backward compatibility

📋 附加信息 / Additional Notes


审查者注意事项 / Reviewer Notes:

@surpercodehang surpercodehang added this to the 3.5.0 milestone Jul 23, 2025
@surpercodehang surpercodehang self-assigned this Jul 23, 2025
@surpercodehang surpercodehang added the type: enhancement A general enhancement label Jul 23, 2025
@surpercodehang surpercodehang moved this to In review in Nova Jul 23, 2025
@surpercodehang surpercodehang changed the base branch from main to 3.5.x July 23, 2025 09:06
@CodeCasterX
Copy link
Member

该修改似乎和注册中心的逻辑有关,当前使用老的注册中心,可能是注册中心的不完善导致了该现象的出现,目前正在推进使用最新的Nacos来作为注册中心的最新实现,我建议,当前的优化仅为临时优化,待Nacos上线后,修改回来,验证是否还存在当前问题。 #178

@surpercodehang surpercodehang force-pushed the enhancement-heart-beat branch from 9aaefb8 to f09c2c5 Compare July 23, 2025 09:27
@CodeCasterX CodeCasterX added the in: fit Issues in FIT modules label Jul 23, 2025
@CodeCasterX CodeCasterX merged commit d7ade4f into ModelEngine-Group:3.5.x Jul 23, 2025
1 check passed
@github-project-automation github-project-automation bot moved this from In review to Done in Nova Jul 23, 2025
surpercodehang added a commit to surpercodehang/fit-framework that referenced this pull request Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: fit Issues in FIT modules type: enhancement A general enhancement

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants