Skip to content

[fel] update langchain loader tools meta #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 30, 2025
Merged

[fel] update langchain loader tools meta #225

merged 2 commits into from
Jul 30, 2025

Conversation

@Mark-Tanbowu
Copy link
Contributor

@Mark-Tanbowu Mark-Tanbowu commented Jul 28, 2025 •
edited by CodeCasterX
Loading

🔗 相关问题 / Related Issue

Issue 链接 / Issue Link: #231

  • 我已经创建了相关 Issue 并进行了讨论 / I have created and discussed the related issue
  • 这是一个微小的修改（如错别字），不需要 Issue / This is a trivial change (like typo fix) that doesn't need an issue

📋 变更类型 / Type of Change

  • 🐛 Bug 修复 / Bug fix (non-breaking change which fixes an issue)
  • ✨ 新功能 / New feature (non-breaking change which adds functionality)
  • 💥 破坏性变更 / Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 文档更新 / Documentation update
  • 🔧 重构 / Refactoring (no functional changes)
  • ⚡ 性能优化 / Performance improvement
  • 🧹 代码清理 / Code cleanup

📝 变更目的 / Purpose of the Change

  1. 将插件注册方式统一为声明式，以便支持自动化元数据生成与加载
  2. 简化插件管理流程，增强与 UI、Agent 等系统的集成能力

📋 主要变更 / Brief Changelog

  1. 使用 @Fitable 装饰器替代 register_callable_tool 手动注册方式
  2. 移除旧的 loader_toolkit 显式注册列表
  3. 所有工具函数参数改为显式类型声明，满足声明式注册要求
  4. 保持工具功能逻辑不变，仅修改注册与声明方式

🧪 验证变更 / Verifying this Change

测试步骤 / Test Steps

  1. 通过相应实现生成元数据
  2. 将插件元数据打包部署入应用进行调试
  3. 输入PDF路径能够正确解析内容

测试覆盖 / Test Coverage

  • 我已经添加了单元测试 / I have added unit tests
  • 所有现有测试都通过 / All existing tests pass
  • 我已经进行了手动测试 / I have performed manual testing

📸 截图 / Screenshots

✅ 贡献者检查清单 / Contributor Checklist

请确保你的 Pull Request 符合以下要求 / Please ensure your Pull Request meets the following requirements:

基本要求 / Basic Requirements:

  • 确保有 GitHub Issue 对应这个变更（微小变更如错别字除外）/ Make sure there is a Github issue filed for the change (trivial changes like typos excluded)
  • 你的 Pull Request 只解决一个 Issue，没有包含其他不相关的变更 / Your PR addresses just this issue, without pulling in other changes - one PR resolves one issue
  • PR 中的每个 commit 都有有意义的主题行和描述 / Each commit in the PR has a meaningful subject line and body

代码质量 / Code Quality:

  • 我的代码遵循项目的代码规范 / My code follows the project's coding standards
  • 我已经进行了自我代码审查 / I have performed a self-review of my code
  • 我已经为复杂的代码添加了必要的注释 / I have commented my code, particularly in hard-to-understand areas

测试要求 / Testing Requirements:

  • 我已经编写了必要的单元测试来验证逻辑正确性 / I have written necessary unit-tests to verify the logic correction
  • 当存在跨模块依赖时，我尽量使用了 mock / I have used mocks when cross-module dependencies exist
  • 基础检查通过：mvn -B clean package -Dmaven.test.skip=true，elsa README 中的编译检查 / Basic checks pass
  • 单元测试通过：mvn clean install / Unit tests pass

文档和兼容性 / Documentation and Compatibility:

  • 我已经更新了相应的文档 / I have made corresponding changes to the documentation
  • 如果有破坏性变更，我已经在 PR 描述中详细说明 / If there are breaking changes, I have documented them in detail
  • 我已经考虑了向后兼容性 / I have considered backward compatibility

📋 附加信息 / Additional Notes

审查者注意事项 / Reviewer Notes:

@Mark-Tanbowu Mark-Tanbowu force-pushed the fel-langchain-loader-tools branch from 4d9dc44 to 75f13de Compare July 29, 2025 02:30
@Mark-Tanbowu Mark-Tanbowu changed the base branch from main to 3.5.x July 29, 2025 02:30
@loveTsong loveTsong added type: enhancement A general enhancement in: fel Issues in FEL(FIT Expression for LLM) modules labels Jul 29, 2025
@loveTsong loveTsong added this to Nova Jul 29, 2025
@loveTsong loveTsong added this to the 3.5.x milestone Jul 29, 2025
@loveTsong loveTsong changed the title fel-langchain-loader-tools-modify-meta [fel] update langchain loader tools meta Jul 29, 2025
@loveTsong loveTsong moved this to In review in Nova Jul 29, 2025
@CodeCasterX CodeCasterX modified the milestones: 3.5.x, 3.5.0 Jul 30, 2025
@CodeCasterX CodeCasterX merged commit 2f92238 into ModelEngine-Group:3.5.x Jul 30, 2025
@github-project-automation github-project-automation bot moved this from In review to Done in Nova Jul 30, 2025
@CodeCasterX CodeCasterX linked an issue Aug 12, 2025 that may be closed by this pull request
更新fel的langchain和llama生态插件元数据 #231
Closed
4 tasks
surpercodehang pushed a commit to surpercodehang/fit-framework that referenced this pull request Oct 28, 2025
@Mark-Tanbowu @surpercodehang
[fel] update langchain loader tools meta (ModelEngine-Group#225)
cbb3af2 
* 修改langchain-loader-tools插件以及元数据

* 修改检视意见

(cherry picked from commit 2f92238)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CodeCasterX CodeCasterX CodeCasterX approved these changes

@loveTsong loveTsong loveTsong approved these changes

Assignees

@Mark-Tanbowu Mark-Tanbowu

Labels

in: fel Issues in FEL(FIT Expression for LLM) modules type: enhancement A general enhancement

Projects

Nova
Status: Done

Milestone

3.5.0

Development

Successfully merging this pull request may close these issues.

更新fel的langchain和llama生态插件元数据

3 participants

@Mark-Tanbowu @CodeCasterX @loveTsong