-
Notifications
You must be signed in to change notification settings - Fork 327
[fit] 修复校验泛型元素为空时的错误 #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
CodeCasterX
merged 4 commits into
ModelEngine-Group:3.5.x
from
Cherished-l:fit-bugfix-35x-validation
Mar 23, 2025
Merged
[fit] 修复校验泛型元素为空时的错误 #7
CodeCasterX
merged 4 commits into
ModelEngine-Group:3.5.x
from
Cherished-l:fit-bugfix-35x-validation
Mar 23, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
CodeCasterX
requested changes
Mar 18, 2025
Member
CodeCasterX
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 注释需要符合团队规范
- 测试命名等细节需要注意
...tension/fit-validation/src/test/java/modelengine/fitframework/validation/annotation/One.java
Outdated
Show resolved
Hide resolved
...extension/fit-validation/src/test/java/modelengine/fitframework/validation/data/Product.java
Show resolved
Hide resolved
...fit-validation/src/test/java/modelengine/fitframework/validation/validator/OneValidator.java
Show resolved
Hide resolved
...lidation/src/test/java/modelengine/fitframework/validation/ValidationDataControllerTest.java
Outdated
Show resolved
Hide resolved
CodeCasterX
reviewed
Mar 19, 2025
...validation/src/test/java/modelengine/fitframework/validation/validator/MinSizeValidator.java
Show resolved
Hide resolved
CodeCasterX
reviewed
Mar 19, 2025
Member
CodeCasterX
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
注解的null值判断逻辑还需要讨论一下
Contributor
Author
|
修改 MinSize -> MaxSize |
CodeCasterX
approved these changes
Mar 23, 2025
Yager-42
pushed a commit
to Yager-42/fit-framework
that referenced
this pull request
Aug 16, 2025
* [fit] 修复校验泛型元素为空时的错误 * [fit] 修改版权 * [fit] 修改检视意见:测试校验注解One -> MinSize * [fit] 测试校验注解修改为集合最大值上限 --------- Co-authored-by: cherish_li <cherish_li@noreply.gitcode.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue:


当嵌套校验中包含泛型元素,且泛型元素为 null 的时候,会出现 NPE
注:红色标注框前的判空操作为新pr所添加代码
pr:
修复错误,并提交单测验证