Skip to content

Conversation

@Cherished-l
Copy link
Contributor

issue:
当嵌套校验中包含泛型元素,且泛型元素为 null 的时候,会出现 NPE
image
注:红色标注框前的判空操作为新pr所添加代码
image

pr:
修复错误,并提交单测验证

@CodeCasterX CodeCasterX self-assigned this Mar 18, 2025
@CodeCasterX CodeCasterX self-requested a review March 18, 2025 16:11
@CodeCasterX CodeCasterX added type: bug A general bug in: fit Issues in FIT modules labels Mar 18, 2025
@CodeCasterX CodeCasterX added this to the 3.5.0 milestone Mar 18, 2025
Copy link
Member

@CodeCasterX CodeCasterX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. 注释需要符合团队规范
  2. 测试命名等细节需要注意

@CodeCasterX CodeCasterX self-requested a review March 19, 2025 16:34
Copy link
Member

@CodeCasterX CodeCasterX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

注解的null值判断逻辑还需要讨论一下

@Cherished-l
Copy link
Contributor Author

修改 MinSize -> MaxSize
更符合测试语境

@CodeCasterX CodeCasterX merged commit 1fbbfe6 into ModelEngine-Group:3.5.x Mar 23, 2025
Yager-42 pushed a commit to Yager-42/fit-framework that referenced this pull request Aug 16, 2025
* [fit] 修复校验泛型元素为空时的错误

* [fit] 修改版权

* [fit] 修改检视意见:测试校验注解One -> MinSize

* [fit] 测试校验注解修改为集合最大值上限

---------

Co-authored-by: cherish_li <cherish_li@noreply.gitcode.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: fit Issues in FIT modules type: bug A general bug

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants