Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New metrics are added for imbalanced data #480

Closed
wants to merge 2 commits into from
Closed

New metrics are added for imbalanced data #480

wants to merge 2 commits into from

Conversation

mcavs
Copy link

@mcavs mcavs commented Feb 20, 2022

Mathews Correlation Coefficient, Balanced Accuracy, Brier Score and log-loss metrics, which are used in case of imbalanced data, are added.

Mathews Correlation Coefficient, Balanced Accuracy, Brier Score and log-loss metrics, which are used in case of imbalanced data, are added.
Copy link
Member

@hbaniecki hbaniecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hbaniecki hbaniecki self-requested a review February 21, 2022 12:14
R/model_performance.R Outdated Show resolved Hide resolved
Copy link
Member

@pbiecek pbiecek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mcavs thank you,
for onboarding of new code please:

This was referenced Feb 21, 2022
@mcavs
Copy link
Author

mcavs commented Feb 21, 2022

@pbiecek 2 added and 3 updated, but I do not know how to add unit test :/

@hbaniecki
Copy link
Member

Hi @mcavs, I could try to add unit tests, but I don't see changes with respect to 2. & 3. (only the code changed looking at https://github.com/ModelOriented/DALEX/pull/480/files).

@mcavs
Copy link
Author

mcavs commented May 10, 2022

Hi @mcavs, I could try to add unit tests, but I don't see changes with respect to 2. & 3. (only the code changed looking at https://github.com/ModelOriented/DALEX/pull/480/files).

Hi @hbaniecki, I created a new pull request consists 2 and 3. You can see it on #505

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants