Unify forests 1 #41
Merged
Unify forests 1 #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first (big) step towards #40: It unifies the output of
getTree()andtreeInfo()and thus makes most of the {ranger} functionality redundant.This PR is relatively large: the code base shrinks by 200 lines of code.
Note: The rds files for the vignette differed from the output, even for the CRAN version of the package. Thus, I have updated them first with the CRAN package of {randomForestExplainer}, and then compared with the output of this PR. The PR does not seem to change any values, and I have also updated these temp files with the PR version.