-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify the Shapes test to use shape-outside rather than shape-inside #1086
Conversation
…the test to be aligned with the specification. From now the Shape test of Modernizr uses the shape-outside property for testing the feature. The following versions of the Shapes specification will contain support for shape-inside property.
review? @stucox @paulirish |
Hey Zoltan! Thanks for the pull Do you know which browsers only support level 1? |
Hi Patrick, For Level 1, CSS Shapes can be applied to floats. (Level one is only about shape-outside.) |
ah, got it. Seems like a reasonable change, since we haven't rolled out the test outside master. Since you are embedded with the spec, do you have any idea on what sort of a timeframe between level 1 and level 2 shipping to top browsers? 12 week, 2 years, etc. My only concern would be if chrome/opera ships level 2 really quickly (relatively speaking), but safari doesn't for another year or so after that, peoples perception of what cssshapes means could be warped (see #1048 for a similar case). |
@patrickkettner So there is a detailed table that tracks browser support for shapes. Right now I think we are on track to having implementations thoroughly match Shapes Level 1 in Blink & WebKit (by extension Chrome, Opera & Safari). If it happens that Shapes Level 2 ships quickly (I think this is not very likely given the ambiguity around certain interactions), then I think we should expand 'support' to mean both |
I agree with nimbupani - it will be a while before shapes level 2 progresses, at least as I've currently defined the next level. For now, it will be most useful just to detect support for shape-outside. |
Modify the Shapes test to use shape-outside rather than shape-inside
Thanks guys! |
Modify the Shapes test to use shape-outside rather than shape-inside
Shapes Level 1 specification contains only shape-outside. I modified the test to be aligned with the specification.
From now the Shape test of Modernizr uses the shape-outside property for testing the feature. The following versions of the Shapes specification will contain support for shape-inside property.