Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fake body for truthy in all non-IE browsers #1506

Merged
merged 1 commit into from
Feb 22, 2015
Merged

Remove fake body for truthy in all non-IE browsers #1506

merged 1 commit into from
Feb 22, 2015

Conversation

niksy
Copy link
Contributor

@niksy niksy commented Jan 30, 2015

Flash detect doesn’t remove fake body when it passes Pan test in non-IE browsers, and since check returns early, it won’t get to blockedDetect check and it won’t remove fake body.

@patrickkettner, since you’re the who created the detect, could you please review it and see if this makes any sense?

@patrickkettner
Copy link
Member

beautiful work! so sorry it took so long to review

patrickkettner added a commit that referenced this pull request Feb 22, 2015
Remove fake body for truthy in all non-IE browsers
@patrickkettner patrickkettner merged commit f87815a into Modernizr:master Feb 22, 2015
@niksy niksy deleted the flash-remove-fake-body branch October 30, 2015 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants