Improve videoautoplay detection #1963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
videoautoplay detection can be flaky. 300ms is a long enough wait for many sites, however there are plenty of other sites where that number is too low. Rather than simply increasing the wait, this commit tries to address the problem by increasing the wait time to 1000ms while re-checking every 200ms to ensure the quickest result. While this might not be enough for every situation, it should cover many more situations.
|
Any chance this is getting to master any time soon? |
|
Thanks @mfairchild365 we'll see how this goes. |
|
@ryanseddon is there a plan to bump version as well? |
skoolbus39
added a commit
to skoolbus39/wdntemplates
that referenced
this pull request
May 3, 2016
As it turns out, the videoautoplay Modernizr test is [is not entirely reliable](Modernizr/Modernizr#1095). @mfairchild365 has submitted [a pull request](Modernizr/Modernizr#1963) to Modernizr which has been merged. In the meantime, I've adjusted the hero content CSS. The video will always play if the videoautoplay test works. If the test fails, we'll fall back to media queries. Video will be shown for browser widths greater than 768px.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
videoautoplay detection can be flaky. 300ms is a long enough wait for many sites, however there are plenty of other sites where that number is too low. Rather than simply increasing the wait, this commit tries to address the problem by increasing the wait time to 1000ms while re-checking every 200ms to ensure the quickest result. While this might not be enough for every situation, it should cover many more situations.