-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SubPixel Font Rendering #602
Conversation
// get actual width of text | ||
width = window.getComputedStyle | ||
? window.getComputedStyle(inner,null).getPropertyValue("width") | ||
: '44px', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like you don't need this constant/magic-value at all. just checkin with window.getComputedStyle
should do the trick?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are right, obviously. I removed the variable width
and the unnecessary assignment. thx!
SubPixel Font Rendering feature detect, closes #602
Thanks @rodneyrehm |
Is this feature working right? I'm getting no-subpixelfont (false) every time. |
There is an issue with initial page zoom. If the page is zoomed, this test currently fails (and we don't have a clue how to circumvent that, yet). |
Thanks for the reply, but I'm still getting false. Here's the example: http://jsfiddle.net/fHUvY/ |
Might detect-zoom help identify the initial zoom level? Looks like an awful lot of code to load for "a simple test", though |
SubPixel Font Rendering feature detect, closes Modernizr#602
Here's a test to determine if a browser has support for SubPixel Font Rendering. (DirectWrite vs. GDI on Windows, for example).
This could be used to switch fonts in case SubPixel Font Rendering is not supported and another font would look better.