Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor 4 #22

Open
wants to merge 1 commit into
base: refactor-3
Choose a base branch
from
Open

Refactor 4 #22

wants to merge 1 commit into from

Conversation

michaeltintiuc
Copy link
Member

@michaeltintiuc michaeltintiuc commented Oct 11, 2022

This is the fourth step of refactoring:

  • We've moved the player health UI component outside of the Player component

The player's health was moved to global context as it's being used by multiple components, it will be further refactored in the future PRs. We've also created a separate component to render the player's health rather than having it in the player component. We've also updated our custom hooks so that we could position our sprites with CSS rather than DOM attributes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant