Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: eslintInstance may not be initialized when calling lintFiles in the worker #40

Merged
merged 3 commits into from
Sep 25, 2024
Merged

fix: eslintInstance may not be initialized when calling lintFiles in the worker #40

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a3f4f56
fix: 修复 worker 模式下 eslintInstance 为undefind的问题
fuxichen Sep 24, 2024
ecf971b
fix: 调整实现方案
fuxichen Sep 25, 2024
cdca14b
chore: add comment
ModyQyW Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions packages/core/src/worker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,19 @@ let eslintInstance: ESLintInstance;
let formatter: ESLintFormatter;
let outputFixes: ESLintOutputFixes;

const initPromise = initializeESLint(options).then((result) => {
eslintInstance = result.eslintInstance;
formatter = result.formatter;
outputFixes = result.outputFixes;
return result;
});

// this file needs to be compiled into cjs, which doesn't support top-level await
// so we use iife here
(async () => {
debug("Initialize ESLint");
const result = await initializeESLint(options);
eslintInstance = result.eslintInstance;
formatter = result.formatter;
outputFixes = result.outputFixes;
// remove this line will cause ts2454
const { eslintInstance, formatter, outputFixes } = await initPromise;
if (options.lintOnStart) {
debug("Lint on start");
lintFiles({
Expand All @@ -43,6 +48,8 @@ let outputFixes: ESLintOutputFixes;
})();

parentPort?.on("message", async (files) => {
// make sure eslintInstance is initialized
if (!eslintInstance) await initPromise;
debug("==== message event ====");
debug(`message: ${files}`);
const shouldIgnore = await shouldIgnoreModule(files, filter, eslintInstance);
Expand Down
Loading