Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent Non Collaborator Aliases Version 2: Using Permission API and Batch Call #6

Merged
merged 10 commits into from
Apr 19, 2024
Merged

Prevent Non Collaborator Aliases Version 2: Using Permission API and Batch Call #6

merged 10 commits into from
Apr 19, 2024

Commits on Apr 9, 2024

  1. Revert "Prevent an alias who is not a collaborator from failing to as… 

    …sign any aliases (#5)"

This reverts commit 034fb67.
    @jamoor-moj
    jamoor-moj committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    e429f0f View commit details
    Browse the repository at this point in the history

  2. add basic framing around checking each username / team slug for permi… 

    …ssions to be added
    @jamoor-moj
    jamoor-moj committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    7b77c3d View commit details
    Browse the repository at this point in the history

  3. temporarily remove previous reviewer restriction

    @jamoor-moj
    jamoor-moj committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    6e8be9c View commit details
    Browse the repository at this point in the history

  4. add error handling, awaits

    @jamoor-moj
    jamoor-moj committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    06f6163 View commit details
    Browse the repository at this point in the history

  5. more debug information

    @jamoor-moj
    jamoor-moj committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    a4eaa0e View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2024

  1. remove debug logging, add prod logging. Pull out the alias/team from … 

    …response and filter reviewers list
    @jamoor-moj
    jamoor-moj committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    e4bda16 View commit details
    Browse the repository at this point in the history

  2. remove temp empty array return

    @jamoor-moj
    jamoor-moj committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    9881195 View commit details
    Browse the repository at this point in the history

  3. forgot to package change

    @jamoor-moj
    jamoor-moj committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    e558547 View commit details
    Browse the repository at this point in the history

  4. add tests for filter_only_collaborators

    @jamoor-moj
    jamoor-moj committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    4771f80 View commit details
    Browse the repository at this point in the history

  5. fix comments

    @jamoor-moj
    jamoor-moj committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    3b01b1d View commit details
    Browse the repository at this point in the history