Task AB#1310794: [LevelDB] Add option to disable seek compaction #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yabmek-msft
changed the title
julio-raffaine
approved these changes
Dec 5, 2024
dango-msft
reviewed
Dec 6, 2024
db/version_set.cc
Outdated
Comment on lines
405
to
406
| f->allowed_seeks--; | ||
| if (f->allowed_seeks <= 0 && file_to_compact_ == nullptr) { | ||
| file_to_compact_ = f; | ||
| file_to_compact_level_ = stats.seek_file_level; | ||
| return true; | ||
| if (!vset_->options_->disable_seek_autocompaction) { |
There was a problem hiding this comment.
Just wondering if this line shouldn't be inside the if as well, in the Apply function we will not set the allowed seeks anymore so doesn't seem like we should be decrementing them as well.
There was a problem hiding this comment.
That's a good point, thanks for catching this! I agree with your assessment and will move the decrementing of allowed_seeks inside the if block.
julio-raffaine
approved these changes
Dec 17, 2024
rohunMS
approved these changes
Dec 19, 2024
yabmek-msft
added a commit
that referenced
this pull request
Dec 20, 2024
) * adding option to disable seek compaction * Fixing failed test: convention is to have bools as uint8_t * addressing feedback: inconsistency between spaces and tabs * addressing feedback: moving allowed_seeks decrement --------- Co-authored-by: Mike Biddlecombe <mike.biddlecombe@blackbirdinteractive.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://dev-mc.visualstudio.com/Minecraft/_workitems/edit/1310794
Moved over the option to disable auto-compaction based on number of seeks. This is based on the two commits in leveldb-mcpe:
Second commit is a clean-up to get unit tests to pass.