Fix unmount cleanup of Facets #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I’ve verified that for keyed lists, React does not call removeChild to change the order in a list. It simply calls `insertInContainerBefore`. More info: https://developer.mozilla.org/en-US/docs/Web/API/Node/insertBefore: > If the given node already exists in the document, insertBefore() moves it from its current position to the new position. (That is, it will automatically be removed from its existing parent before appending it to the specified new parent.)
xaviervia
reviewed
Nov 5, 2021
Co-authored-by: Fernando Via Canel <fernando.via@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation in
@react-facet/dom-fiberwasn't correctly removing all subscriptions of Facets when unmounting.This wasn't a problem in our original implementation of
@react-facet/dom-components, and wasn't apparent in our current production screens (as they don't unmount), but can be quite problematic.Added some extra unit tests.