Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding bigint to Value type #129

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Adding bigint to Value type #129

merged 1 commit into from
Sep 20, 2023

Conversation

Tommy-Malone-ZOS
Copy link
Contributor

We use 64 bit handles for entities in our game engine which we pass to JS as bigints. We wish to make these handles into facets, thus we need them Value to include them.

pirelenito
pirelenito approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@pirelenito pirelenito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution ❤️

@pirelenito pirelenito merged commit d609b6d into Mojang:main Sep 20, 2023
@Tommy-Malone-ZOS Tommy-Malone-ZOS deleted the add-bigint-to-Value branch September 20, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pirelenito pirelenito pirelenito approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tommy-Malone-ZOS @pirelenito