Fix 1.20.5 JAR not being executable #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The package for the 1.20.5 Main class is slicer instead of com.mojang.slicer, which makes the JAR not executable, as the manifest points to com.mojang.slicer.Main and not slicer.Main. This seems to be a mistake, as all other Main classes are in the com.mojang.slicer package. This changes the package and adjusts the directory to be consistent with other Main classes, and thus fixes the issue of the JAR not being executable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The package for the 1.20.5
Mainclass isslicerinstead ofcom.mojang.slicer, which makes the JAR not executable, as the manifest points tocom.mojang.slicer.Mainand notslicer.Main. This seems to be a mistake, as all otherMainclasses are in thecom.mojang.slicerpackage.This changes the package and adjusts the directory to be consistent with other
Mainclasses, and thus fixes the issue of the JAR not being executable.Fixes #10.