Slice experience orbs and moon phases #13
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With 1.20.5's long-awaited splitting of map icons into individual files, this means that the only two classic-style texture atlases yet to be split are experience orbs and moon phases. Since there's just two of them, why not rip this bandaid off and get them split just before 1.20.5 releases to limit any subsequent migrations needed by resource pack authors?
Changes:
There would be two new atlases generated to deal with these newly split textures - one for experience orbs and another for all celestial bodies (the sun and all phases of the moon).
Obviously a commit like this is probably trivial compared to the code changes needed in the actual game to support split textures like these, but in the slim event that this does happen I hope I've made the process just a bit smoother for all involved. I would have done this a month ago, but #10 was a blocker.
Some things to note that may be relevant: