Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Models: Consistent model nomenclature moving forward #167

Merged
merged 2 commits into from
Nov 12, 2019
Merged

Models: Consistent model nomenclature moving forward #167

merged 2 commits into from
Nov 12, 2019

Conversation

dgasmith
Copy link
Collaborator

@dgasmith dgasmith commented Nov 8, 2019

Description

Renames models according to #155.

Status

  • Changelog updated
  • Ready to go

@codecov
Copy link

codecov bot commented Nov 8, 2019

Codecov Report

Merging #167 into master will decrease coverage by 0.03%.
The diff coverage is 90.62%.

loriab
loriab approved these changes Nov 8, 2019
View reviewed changes
qcelemental/models/results.py Outdated Show resolved Hide resolved
@dgasmith dgasmith merged commit 52c8171 into MolSSI:master Nov 12, 2019
@dgasmith dgasmith deleted the modelnames branch November 12, 2019 15:13
@dgasmith dgasmith mentioned this pull request Nov 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loriab loriab loriab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dgasmith @loriab