Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Action btwn QCEl and QCSk #218

Closed
wants to merge 27 commits into from
Closed

GitHub Action btwn QCEl and QCSk #218

wants to merge 27 commits into from

Conversation

loriab
Copy link
Collaborator

@loriab loriab commented Mar 3, 2020

Description

Continues from #204. Generate schema from pydantic qcel for models owned by qcsk, compare them, and issue PR to latter in case change to qcel would affect qcsk. Part of MolSSI/QCSchema#68 effort to consolidate single source of truth here and community discussion there.

  • because secrets not passed to PRs from forks, these'll have to be internal PRs. I don't understand how codecov is working from fork PRs.
  • I think this is pretty much ready. the whole sequence is:

Changelog description

Status

  • Code base linted
  • Ready to go

@codecov
Copy link

codecov bot commented Mar 3, 2020

Codecov Report

Merging #218 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@loriab
Copy link
Collaborator Author

loriab commented Sep 4, 2020

This has been subsumed into #237

@loriab loriab closed this Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant