-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allowing torchani to use GPU #327
Conversation
Add option allowing perform calculation in gpu
Allow the model to run on GPU
more cpu added
automatically use gpu when available
delete device config
That sounds reasonable, I've changed the code according to your suggestion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look great to me. Thanks for the contribution!
Once you fix the linting problems with make format
, this should be ready to merge.
@loriab , do you want to review this as well? Or, can I click the button?
qcengine/config.py
Outdated
@@ -158,7 +158,7 @@ class TaskConfig(pydantic.BaseModel): | |||
scratch_messy: bool = pydantic.Field( | |||
False, description="Leave scratch directory and contents on disk after completion." | |||
) | |||
|
|||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Introducing the whitespace here probably caused a problem with our linter.
Could you run make format
and issue a commit with the changed files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done by d7ced82 😉
code format using `make format`
Thanks @WardLT , merge at will. |
Description
Added config for torchani to use GPU, related to this issue #326.
Now we can use
local_options={'device':'cuda'}
to assign the device: