Remove overzealous cache usage for entry and spec names

MolSSI · Apr 11, 2024 · bae24bf · bae24bf
1 parent 099684f
commit bae24bf
Showing 1 changed file with 8 additions and 8 deletions.
diff --git a/qcportal/qcportal/dataset_models.py b/qcportal/qcportal/dataset_models.py
@@ -525,10 +525,10 @@ def fetch_specifications(
     @property
     def specification_names(self) -> List[str]:
         if not self._specification_names:
-            self._specification_names = self._cache_data.get_specification_names()
-
-        if not self._specification_names and not self.is_view:
-            self.fetch_specification_names()
+            if self.is_view:
+                self._specification_names = self._cache_data.get_specification_names()
+            else:
+                self.fetch_specification_names()
 
         return self._specification_names
 
@@ -769,10 +769,10 @@ def iterate_entries(
     @property
     def entry_names(self) -> List[str]:
         if not self._entry_names:
-            self._entry_names = self._cache_data.get_entry_names()
-
-        if not self._entry_names and not self.is_view:
-            self.fetch_entry_names()
+            if self.is_view:
+                self._entry_names = self._cache_data.get_entry_names()
+            else:
+                self.fetch_entry_names()
 
         return self._entry_names