Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Managers claiming/returning should be marked as modified #851

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Conversation

bennybp
Copy link
Contributor

@bennybp bennybp commented Oct 16, 2024

Description

When a manager claims or returns tasks, that should count towards the server as having heard from the manager (for heartbeat purposes). Without this, a manager could get stuck returning or claiming lots of data, but then be marked as inactive by the server since the heartbeat mechanism has been block by the other actions.

This is a bit of a bandaid. The next iteration of the manager should probably use a separate threads for heartbeat and updates, which would also help.

Hopefully helps with #850

Status

  • Code base linted
  • Ready to go

@bennybp bennybp merged commit 0557078 into main Oct 16, 2024
19 checks passed
@bennybp bennybp deleted the manager_mod branch October 16, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant