Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple schema examples #40

Merged
merged 4 commits into from
Apr 5, 2018
Merged

Simple schema examples #40

merged 4 commits into from
Apr 5, 2018

Conversation

dgasmith
Copy link
Collaborator

@dgasmith dgasmith commented Apr 2, 2018

Description

Provide a few simple, schema examples as requested in #39. Again, these are not meant to be complete, but a place to spur further discussion.


calcinfo_properties = {}

calcinfo_properties["calcinfo_nbasis"] = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to duplicate calcinfo in the key name if it's already in the filename and the struct name?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep in mind the structure is flattened. The python is just there to help build out a structure instead of writing a single 5k line schema.

"description": "The number of molecular orbitals for the computation."
}

calcinfo_properties["calcinfo_nalapha"] = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nalapha -> nalpha

"type": "number",
"multipleOf": 1.0,
"description": "The number of beta electrons in the computation."
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does something like reference (RHF/UHF/ROHF) go in calcinfo_properties or scf_properties? I guess I am not clear on the border where different steps in a computation get news instances of the schema. For example, you may run the SCF step with ROHF but then CCSD with UHF, and if both SCF/CCSD steps are part of the same instance, something (like the reference) needs to be present in multiple places.

This is related to the discussion about properties (HF vs. CCSD dipole moment); I think the same thing applies.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure there is a clear line yet. To me, I think thats a single computation. I kind of feel those specification might come in method as the choice to use ROHF SCF/UHF CCSD is a user setting. properties seems to be purely as the result.

@langner
Copy link

langner commented Apr 3, 2018

Can/should we also include the logfiles from which those JSONs were created?

@dgasmith
Copy link
Collaborator Author

dgasmith commented Apr 3, 2018

@langner Its an option to output, I didn't want to clutter up the examples or start introducing program specific data yet.

@langner
Copy link

langner commented Apr 3, 2018

@langner Its an option to output, I didn't want to clutter up the examples or start introducing program specific data yet.

Understood. Another option would be to reference one of cclib's unit test logfiles.

@dgasmith
Copy link
Collaborator Author

dgasmith commented Apr 3, 2018

Good point, can we do this once we stabilize a bit on what the schema looks like. The current iteration is fairly straight forward to autogenerate from existing programs.

@bennybp bennybp merged commit 3ac723d into MolSSI:master Apr 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants