Skip to content

Fix leave the response for the event consumer #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix leave the response for the event consumer #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6302f0c
Fix leave the response for the event consumer
lukavia Feb 8, 2024
74048db
#Fix tests to expect the initial Rotate Event
lukavia Feb 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/MySQLReplication/BinLog/BinLogSocketConnect.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,6 @@ private function setBinLogDump(): void
$data .= $binFileName;

$this->socket->writeToSocket($data);
$this->getResponse();

$binLogCurrent->setBinLogPosition($binFilePos);
$binLogCurrent->setBinFileName($binFileName);
Expand Down
2 changes: 2 additions & 0 deletions tests/Integration/BaseTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
use MySQLReplication\Event\DTO\EventDTO;
use MySQLReplication\Event\DTO\FormatDescriptionEventDTO;
use MySQLReplication\Event\DTO\QueryDTO;
use MySQLReplication\Event\DTO\RotateDTO;
use MySQLReplication\Event\DTO\TableMapDTO;
use MySQLReplication\MySQLReplicationFactory;
use PHPUnit\Framework\TestCase;
Expand Down Expand Up @@ -61,6 +62,7 @@ protected function setUp(): void

$this->connect();

self::assertInstanceOf(RotateDTO::class, $this->getEvent());
self::assertInstanceOf(FormatDescriptionEventDTO::class, $this->getEvent());
self::assertInstanceOf(QueryDTO::class, $this->getEvent());
self::assertInstanceOf(QueryDTO::class, $this->getEvent());
Expand Down
1 change: 1 addition & 0 deletions tests/Integration/BasicTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,6 +401,7 @@ private function connectWithProvidedEventDispatcher(EventDispatcherInterface $ev
$this->connection->executeStatement('USE ' . $this->database);
$this->connection->executeStatement('SET SESSION sql_mode = \'\';');

self::assertInstanceOf(RotateDTO::class, $this->getEvent());
self::assertInstanceOf(FormatDescriptionEventDTO::class, $this->getEvent());
self::assertInstanceOf(QueryDTO::class, $this->getEvent());
self::assertInstanceOf(QueryDTO::class, $this->getEvent());
Expand Down