-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: set and update user role #151
feat: set and update user role #151
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would wait for @rutajdash to review
The basic overview looks good.
Two things
- This feature branch is not rebased from the latest base branch
- ESLint failure is there in existing code
Also, it is highly recommended to have tests for the project. You can start incrementally with tests for new code you write and then slowly cover rest of code. JS code(without TS), that too for server side is risky.
CC: @120EE0692
@DesignrKnight |
… into graphql/user-role-query-mutation
… into graphql/user-role-query-mutation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please complete the prior changes.
Solved or Linked Issues
Reference any and all issues solved and related to this pull request here. Mention if there are none.
Description and Changes
Please describe your pull request with all changes made.
Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.
Post merge checklist