Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup JSDoc #16

Merged
merged 20 commits into from
Dec 30, 2020
Merged

Setup JSDoc #16

merged 20 commits into from
Dec 30, 2020

Conversation

rutajdash
Copy link
Member

  • Setup and configured jsdoc
  • Add NPM scripts to create docs
  • Document pre-existing completed files

Solves #1

@rutajdash rutajdash self-assigned this Dec 28, 2020
@rutajdash rutajdash added dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation labels Dec 28, 2020
@rutajdash rutajdash mentioned this pull request Dec 28, 2020
Closed
@DesignrKnight DesignrKnight changed the title Setup jsdoc Setup JSDoc Dec 28, 2020
@DesignrKnight DesignrKnight linked an issue Dec 28, 2020 that may be closed by this pull request
Setup JSDoc for documentation #1
Closed
Thesmader
Thesmader reviewed Dec 28, 2020
View reviewed changes
package.json Outdated Show resolved Hide resolved
Thesmader
Thesmader reviewed Dec 28, 2020
View reviewed changes
package.json Outdated Show resolved Hide resolved
DesignrKnight
DesignrKnight approved these changes Dec 28, 2020
View reviewed changes
app.js Outdated Show resolved Hide resolved
@DesignrKnight
Copy link
Member

Hey, I will merge #14 now, there are conflicts already. If there arises more, resolve that and comment. Will merge

@Thesmader
Copy link
Member

Now we have got conflicts in package-lock.json here, since #14 was merged 😩.

@DesignrKnight
Copy link
Member

Now we have got conflicts in package-lock.json here, since #14 was merged 😩.

It was there even before itself

rutajdash and others added 17 commits December 30, 2020 16:52
@rutajdash
Copy link
Member Author

@Thesmader @DesignrKnight ready for merge

@DesignrKnight DesignrKnight merged commit 5a67ce1 into Monday-Morning:development Dec 30, 2020
@rutajdash rutajdash deleted the wip/setup/jsdoc branch December 30, 2020 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thesmader Thesmader Thesmader left review comments

@DesignrKnight DesignrKnight DesignrKnight approved these changes

Assignees

@rutajdash rutajdash

Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setup JSDoc for documentation
3 participants
@rutajdash @DesignrKnight @Thesmader