Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Graphql Queries for Squiggle #91

Merged

Conversation

SriramPatibanda
Copy link
Member

@SriramPatibanda SriramPatibanda commented May 22, 2021

Solved or Linked Issues

Fixes #90

Description and Changes

  • Add Squiggle Type.
  • Add Squiggle query.
  • Add resolvers for required queries.

Note: Working of APIs needed to be checked and tested.

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are requesting to pull a work/topic/feature/bugfix branch (right side). Don't request your default branch!
  • Make sure you are making a pull request against the development (left side). Also you should start your branch off default branch and follow the branch naming guidelines.
  • Check the commit's or even all commits' message styles matches our requested structure.
  • Check your code additions will fail neither code linting checks nor unit test.
  • I have added necessary documentation and mentioned the related issues (if appropriate)
  • I have added the appropriate labels, requested a review from a repository manager and assigned myself to this pull request.

Post merge checklist

@rutajdash rutajdash added the wip Work in Progress label May 22, 2021
},
listSquiggles: {
description: 'Retrieves a list of all the Squiggles',
type: new GraphQLNonNull(new GraphQLList(GraphQLID)),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Directly return the squiggle, not just the ID

Suggested change
type: new GraphQLNonNull(new GraphQLList(GraphQLID)),
type: new GraphQLNonNull(new GraphQLList(SquiggleType)),

listSquiggles: {
description: 'Retrieves a list of all the Squiggles',
type: new GraphQLNonNull(new GraphQLList(GraphQLID)),
args: {},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set limit-offset combo to allow for pagination

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean to take the offset and limit as arguments? @rutajdash

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup

@rutajdash rutajdash self-requested a review May 23, 2021 08:14
@github-actions
Copy link

Prettier Response:
server/schema/user/user.model.js
test/helpers/authorization.test.js

@rutajdash
Copy link
Member

@VishalR3 ready for merge

@rutajdash rutajdash merged commit db00c3e into Monday-Morning:development May 23, 2021
@rutajdash rutajdash deleted the wip/gql/squiggle branch May 23, 2021 19:39
@rutajdash rutajdash added this to the Phase 1 Launch milestone Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wip Work in Progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Squiggle Schema
2 participants