-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Graphql Queries for Squiggle #91
Add Graphql Queries for Squiggle #91
Conversation
}, | ||
listSquiggles: { | ||
description: 'Retrieves a list of all the Squiggles', | ||
type: new GraphQLNonNull(new GraphQLList(GraphQLID)), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Directly return the squiggle, not just the ID
type: new GraphQLNonNull(new GraphQLList(GraphQLID)), | |
type: new GraphQLNonNull(new GraphQLList(SquiggleType)), |
listSquiggles: { | ||
description: 'Retrieves a list of all the Squiggles', | ||
type: new GraphQLNonNull(new GraphQLList(GraphQLID)), | ||
args: {}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Set limit-offset combo to allow for pagination
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean to take the offset and limit as arguments? @rutajdash
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup
Prettier Response: |
@VishalR3 ready for merge |
Solved or Linked Issues
Fixes #90
Description and Changes
Note: Working of APIs needed to be checked and tested.
Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.
Post merge checklist