Refactor to support HPOS #71
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| <?php | ||
| if ( ! defined( 'ABSPATH' ) ) { | ||
| exit; | ||
| } // Exit if accessed directly | ||
|
|
||
| use Automattic\WooCommerce\Utilities\OrderUtil; | ||
|
|
||
| interface OrderStorageInterface { | ||
|
There was a problem hiding this comment. Having If the problem is that we already use the name There was a problem hiding this comment. That's exactly the issue I saw with clashing names. Thanks for the input, learning a lot about OOP best practices here, great stuff :) |
||
| public function get_meta_data($order, $meta_key, $meta_value); | ||
| public function add_meta_data($order, $meta_key, $meta_value); | ||
| public function update_meta_data($order, $meta_key, $meta_value); | ||
| public function delete_meta_data($order, $meta_key); | ||
| public function save($order); | ||
| } | ||
|
|
||
| class HPOSOrderStorage implements OrderStorageInterface { | ||
| public function get_meta_data($order, $meta_key, $meta_value) { | ||
| return $order->get_meta($meta_key, $meta_value); | ||
| } | ||
|
|
||
| public function add_meta_data($order, $meta_key, $meta_value) { | ||
| $order->add_meta_data($meta_key, $meta_value); | ||
| } | ||
|
|
||
| public function update_meta_data($order, $meta_key, $meta_value) { | ||
| $order->update_meta_data($meta_key, $meta_value); | ||
| } | ||
|
|
||
| public function delete_meta_data($order, $meta_key) { | ||
| $order->delete_meta_data($meta_key); | ||
| } | ||
|
|
||
| public function save($order) { | ||
| $order->save(); | ||
| } | ||
| } | ||
|
|
||
| class CPTOrderStorage implements OrderStorageInterface { | ||
| public function get_meta_data($order, $meta_key, $meta_value) { | ||
| return get_post_meta($order->get_id(), $meta_key, $meta_value); | ||
| } | ||
|
|
||
| public function add_meta_data($order, $meta_key, $meta_value) { | ||
| add_post_meta($order->get_id(), $meta_key, $meta_value); | ||
| } | ||
|
|
||
| public function update_meta_data($order, $meta_key, $meta_value) { | ||
| update_post_meta($order->get_id(), $meta_key, $meta_value); | ||
| } | ||
|
|
||
| public function delete_meta_data($order, $meta_key) { | ||
| delete_post_meta($order->get_id(), $meta_key); | ||
| } | ||
|
|
||
| public function save($order) { | ||
| return; // Do nothing, CPT doesn't use save | ||
| } | ||
| } | ||
|
|
||
| class OrderStorage { | ||
| public static function current() { | ||
eric-thelin marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| if (OrderUtil::custom_orders_table_usage_is_enabled()) { | ||
| return new HPOSOrderStorage(); | ||
| } else { | ||
| return new CPTOrderStorage(); | ||
| } | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pair of lines with delete + update is repeating itself in multiple places. In order to reduce duplication we could introduce a
replace_meta_datamethod on the order storage.