Save with cascade=True fix for unsaved child documents #2605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Save the children documents first to avoid the issue where a parent cannot save due to having new children documents.
nickfrev
changed the title
- Created a new base field (SaveableBaseField) which allows a field to marked as savable during a cascade save. - Each SaveableBaseField defines a save method which describes how it will deal with a cascade save call this allows lists, dicts, and maps to be effected during a cascade save. - Added an _is_saving flag during Document save to avoid saving a document that is already in the process of being saved. (Caused if there is a circular reference.)
- Allows for users to cascade save unsaved documents even if a cycle exists.
|
This Pull request is a subset of a larger pull request which include more issue fixes and features: |
Multiple fixes for cascade=True save issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for #1236
Moved the cascade save portion of the Document.save method above the validation check. This does mean that there is a possibility that a child document could be saved while the parent document is not valid for another reason but this would already occur anyway with the current work arounds to this issue.
This move also removed this code block from the try-catch statement however all errors should be being caught by Document.cascade_save anyway.