Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(version): add version up script #228

Merged

Conversation

SARDONYX-sard
Copy link
Collaborator

This is the code that was published in the discussion.

In some cases, you may need to tweak the settings or code.

INFO

  • The Python3 environment I tested is v3.12.3.
    (It will probably work around 3.8. Older than that may not be able to interpret type annotations and may cause errors...)
  • Commit hash at time of testing: chore: version update

FIX

  • The code I published in the discussion was after I used the linter and had to be changed a bit to get it to work. My apologies.
-    r"static readonly Version currentVersion = new \((\d+), (\d+), (\d+)\);"
+    r"static readonly Version currentVersion = new Version\((\d+), (\d+), (\d+)\);"
  • Bug fix (without "not" the meaning is reversed)
-    if dry_run:
+    if not dry_run:

The Python3 environment we tested is v3.12.3.
@Monitor221hz Monitor221hz merged commit da23202 into Monitor221hz:main Jun 5, 2024
1 check passed
@SARDONYX-sard SARDONYX-sard deleted the feature/add-version-up-script branch June 5, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants